From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: saravanak@google.com, marcorr@google.com,
gregkh@linuxfoundation.org, linux-nvme@lists.infradead.org,
iommu@lists.linux-foundation.org, kbusch@kernel.org,
robin.murphy@arm.com, Christoph Hellwig <hch@lst.de>,
jxgao@google.com
Subject: Re: [PATCH 6/9] swiotlb: refactor swiotlb_tbl_map_single
Date: Mon, 22 Feb 2021 14:29:37 -0500 [thread overview]
Message-ID: <YDQGIb4YqFpTKfyB@Konrads-MacBook-Pro.local> (raw)
In-Reply-To: <70edceb03e4bf283072397f9563dfc4162aec92a.camel@suse.de>
> > +static int find_slots(struct device *dev, size_t alloc_size)
> > +{
> > + unsigned long boundary_mask = dma_get_seg_boundary(dev);
> > + dma_addr_t tbl_dma_addr =
> > + phys_to_dma_unencrypted(dev, io_tlb_start) & boundary_mask;
> > + unsigned int max_slots = get_max_slots(boundary_mask);
>
> 'max_slots' should be 'unsigned long' here. Breaks SWIOTLB on RPi4. Do you want
> me to send a fix or you prefer editing the patch?
I can roll it in. Thx!
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-02-22 19:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 16:03 preserve DMA offsets when using swiotlb v2 Christoph Hellwig
2021-02-07 16:03 ` [PATCH 1/9] driver core: add a min_align_mask field to struct device_dma_parameters Christoph Hellwig
2021-02-07 16:03 ` [PATCH 2/9] swiotlb: add a IO_TLB_SIZE define Christoph Hellwig
2021-02-07 16:03 ` [PATCH 3/9] swiotlb: factor out an io_tlb_offset helper Christoph Hellwig
2021-02-07 16:03 ` [PATCH 4/9] swiotlb: factor out a nr_slots helper Christoph Hellwig
2021-02-07 16:03 ` [PATCH 5/9] swiotlb: clean up swiotlb_tbl_unmap_single Christoph Hellwig
2021-02-07 16:03 ` [PATCH 6/9] swiotlb: refactor swiotlb_tbl_map_single Christoph Hellwig
2021-02-22 19:05 ` Nicolas Saenz Julienne
2021-02-22 19:29 ` Konrad Rzeszutek Wilk [this message]
2021-02-23 7:25 ` Christoph Hellwig
2021-02-07 16:03 ` [PATCH 7/9] swiotlb: don't modify orig_addr in swiotlb_tbl_sync_single Christoph Hellwig
2021-02-07 16:03 ` [PATCH 8/9] swiotlb: respect min_align_mask Christoph Hellwig
2021-02-07 16:03 ` [PATCH 9/9] nvme-pci: set min_align_mask Christoph Hellwig
[not found] ` <20210209084156.GA32320@lst.de>
2021-02-09 8:46 ` preserve DMA offsets when using swiotlb v2 Greg KH
2021-02-09 19:49 ` Jianxiong Gao via iommu
2021-02-19 18:13 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDQGIb4YqFpTKfyB@Konrads-MacBook-Pro.local \
--to=konrad.wilk@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jxgao@google.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marcorr@google.com \
--cc=nsaenzjulienne@suse.de \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).