From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD34C432BE for ; Wed, 11 Aug 2021 13:50:06 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B04E160FD9 for ; Wed, 11 Aug 2021 13:50:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B04E160FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7CB0D401EA; Wed, 11 Aug 2021 13:50:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6U3n1RCl50is; Wed, 11 Aug 2021 13:50:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 529CD401E3; Wed, 11 Aug 2021 13:50:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1E2ACC0010; Wed, 11 Aug 2021 13:50:01 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4FFDCC000E for ; Wed, 11 Aug 2021 13:50:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 314764021E for ; Wed, 11 Aug 2021 13:50:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aXu9e7vFL4YD for ; Wed, 11 Aug 2021 13:49:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by smtp2.osuosl.org (Postfix) with ESMTPS id 89E7A4021C for ; Wed, 11 Aug 2021 13:49:59 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="215151733" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="215151733" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 06:49:58 -0700 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="445932257" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 06:49:55 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mDoc8-007wPH-L7; Wed, 11 Aug 2021 16:49:48 +0300 Date: Wed, 11 Aug 2021 16:49:48 +0300 From: Andy Shevchenko To: Lu Baolu Subject: Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file Message-ID: References: <20210729163538.40101-1-andriy.shevchenko@linux.intel.com> <3c7663db-5b1e-3e00-3ff1-381c7a107ac9@linux.intel.com> <17a2b3f2-747d-2798-7fea-5846eec0b1fe@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <17a2b3f2-747d-2798-7fea-5846eec0b1fe@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: Joerg Roedel , David Woodhouse , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Jul 30, 2021 at 09:01:41PM +0800, Lu Baolu wrote: > On 2021/7/30 16:05, Andy Shevchenko wrote: > > On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote: > > > On 7/30/21 12:35 AM, Andy Shevchenko wrote: > > > > Compiler is not happy about hidden declaration of intel_iommu_ops. > > > > > > > > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static? > > > > > > > > Move declaration to header file to make compiler happy. > > > > > > Thanks for the cleanup. Sharing data structures between different files > > > doesn't seem to be a good design. How about adding a helper so that the > > > intel_iommu_ops could be a static one? > > > > Whatever suits the purpose. > > Can you apply patch 2 of this series, please? > > > > Yes, I will. Thanks! Gentle reminder. -- With Best Regards, Andy Shevchenko _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu