From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"Liu, Jingqi" <jingqi.liu@intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Nicolin Chen <nicolinc@nvidia.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] iommu: Prevent RESV_DIRECT devices from blocking domains
Date: Tue, 27 Jun 2023 12:47:47 -0300 [thread overview]
Message-ID: <ZJsEo2eqDdV0Mska@nvidia.com> (raw)
In-Reply-To: <f1b2e7fa-7be3-9e4b-1eba-5dba01b88c19@linux.intel.com>
On Tue, Jun 27, 2023 at 04:01:01PM +0800, Baolu Lu wrote:
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index e59de7852067..3be88b5f36bb 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -962,6 +962,9 @@ static int iommu_create_device_direct_mappings(struct
> iommu_domain *domain,
> pg_size = domain->pgsize_bitmap ? 1UL <<
> __ffs(domain->pgsize_bitmap) : 0;
> INIT_LIST_HEAD(&mappings);
>
> + if (WARN_ON_ONCE((domain->type & __IOMMU_DOMAIN_PAGING) &&
> !pg_size))
> + return -EINVAL;
Calling this function with an identity domain is expected, it must
return 0.
Jason
next prev parent reply other threads:[~2023-06-27 15:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 3:51 [PATCH 0/2] Prevent RESV_DIRECT devices from user assignment Lu Baolu
2023-06-07 3:51 ` [PATCH 1/2] iommu: Prevent RESV_DIRECT devices from blocking domains Lu Baolu
2023-06-12 8:28 ` Liu, Jingqi
2023-06-13 3:14 ` Baolu Lu
2023-06-27 7:54 ` Tian, Kevin
2023-06-27 8:01 ` Baolu Lu
2023-06-27 8:15 ` Tian, Kevin
2023-06-27 8:21 ` Baolu Lu
2023-06-27 15:47 ` Jason Gunthorpe [this message]
2023-06-19 13:33 ` Robin Murphy
2023-06-19 13:41 ` Jason Gunthorpe
2023-06-19 14:20 ` Robin Murphy
2023-06-19 15:30 ` Jason Gunthorpe
2023-06-27 8:10 ` Tian, Kevin
2023-06-27 15:49 ` Jason Gunthorpe
2023-06-07 3:51 ` [PATCH 2/2] iommu/vt-d: Remove rmrr check in domain attaching device path Lu Baolu
2023-06-23 16:49 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJsEo2eqDdV0Mska@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jingqi.liu@intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).