From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ABEC31E5B for ; Tue, 18 Jun 2019 23:15:51 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD3EF20873 for ; Tue, 18 Jun 2019 23:15:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD3EF20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 93047BA0; Tue, 18 Jun 2019 23:15:51 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 938F5AD7 for ; Tue, 18 Jun 2019 23:15:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from Galois.linutronix.de (Galois.linutronix.de [146.0.238.70]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2AA0D180 for ; Tue, 18 Jun 2019 23:15:50 +0000 (UTC) Received: from p5b06daab.dip0.t-ipconnect.de ([91.6.218.171] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hdNKG-0008Hx-Ui; Wed, 19 Jun 2019 01:15:41 +0200 Date: Wed, 19 Jun 2019 01:15:39 +0200 (CEST) From: Thomas Gleixner To: Ricardo Neri Subject: Re: [RFC PATCH v4 18/21] x86/apic: Add a parameter for the APIC delivery mode In-Reply-To: <20190618224738.GC30488@ranerica-svr.sc.intel.com> Message-ID: References: <1558660583-28561-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1558660583-28561-19-git-send-email-ricardo.neri-calderon@linux.intel.com> <20190618224738.GC30488@ranerica-svr.sc.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 Cc: Kate Stewart , Peter Zijlstra , Jan Kiszka , Ricardo Neri , Stephane Eranian , Ingo Molnar , Wincy Van , Ashok Raj , x86@kernel.org, Andi Kleen , Borislav Petkov , "Eric W. Biederman" , "Ravi V. Shankar" , Bjorn Helgaas , Juergen Gross , Tony Luck , Randy Dunlap , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jacob Pan , Philippe Ombredanne X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Tue, 18 Jun 2019, Ricardo Neri wrote: > On Sun, Jun 16, 2019 at 11:55:03AM +0200, Thomas Gleixner wrote: > > On Thu, 23 May 2019, Ricardo Neri wrote: > > > > > > struct irq_cfg { > > > - unsigned int dest_apicid; > > > - unsigned int vector; > > > + unsigned int dest_apicid; > > > + unsigned int vector; > > > + enum ioapic_irq_destination_types delivery_mode; > > > > And how is this related to IOAPIC? > > In my view, IOAPICs can also be programmed with a delivery mode. Mode > values are the same for MSI interrupts. > > I know this enum exists already, but in > > connection with MSI this does not make any sense at all. > > Is the issue here the name of the enumeration? > > > > > > + > > > + /* > > > + * Initialize the delivery mode of this irq to match the > > > + * default delivery mode of the APIC. This is useful for > > > + * children irq domains which want to take the delivery > > > + * mode from the individual irq configuration rather > > > + * than from the APIC. > > > + */ > > > + apicd->hw_irq_cfg.delivery_mode = apic->irq_delivery_mode; > > > > And here it's initialized from apic->irq_delivery_mode, which is an > > u32. Intuitive and consistent - NOT! > > Yes, this is wrong. Then should the member in the structure above be an > u32 instead of enum ioapic_irq_destination_types? > > Thanks and BR, > Ricardo > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu