From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3BDC43331 for ; Wed, 1 Apr 2020 13:01:39 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B570206E9 for ; Wed, 1 Apr 2020 13:01:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J8t0Urh1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B570206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 604368815E; Wed, 1 Apr 2020 13:01:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jqQVyKwVkygI; Wed, 1 Apr 2020 13:01:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 2E52288081; Wed, 1 Apr 2020 13:01:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 27E36C1AE2; Wed, 1 Apr 2020 13:01:38 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F17AC089F for ; Wed, 1 Apr 2020 13:01:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F04F0204C0 for ; Wed, 1 Apr 2020 13:01:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Od9RG-lgDjW for ; Wed, 1 Apr 2020 13:01:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by silver.osuosl.org (Postfix) with ESMTPS id B423820407 for ; Wed, 1 Apr 2020 13:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585746093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKnrkes6duPnh7WRFHiitDNcRHlVg7gWo+yEaEr5RVY=; b=J8t0Urh1SLNPvmyjpNqdgRlxqKnyppxFWdHWatP4X9wVvpwdQ3VGPI3sGxoFhYqBfGvwyX FVT/mADQcL+pjUhS2KPi8P8QYssmFALAZYw59StBAMWwjk7t6IQXpwyGOT9Z7KlpzEyy6E 8NtetoVwKallC/Zxo4LuhWOlS++/uRU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-gGle2qAOM_O7Y-Yt6NQ1fQ-1; Wed, 01 Apr 2020 09:01:29 -0400 X-MC-Unique: gGle2qAOM_O7Y-Yt6NQ1fQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B32321085981; Wed, 1 Apr 2020 13:01:22 +0000 (UTC) Received: from [10.36.112.58] (ovpn-112-58.ams2.redhat.com [10.36.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC0DA61072; Wed, 1 Apr 2020 13:01:13 +0000 (UTC) Subject: Re: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace To: "Liu, Yi L" , "alex.williamson@redhat.com" References: <1584880325-10561-1-git-send-email-yi.l.liu@intel.com> <1584880325-10561-6-git-send-email-yi.l.liu@intel.com> From: Auger Eric Message-ID: Date: Wed, 1 Apr 2020 15:01:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Cc: "jean-philippe@linaro.org" , "Tian, Kevin" , "Raj, Ashok" , "kvm@vger.kernel.org" , "Tian, Jun J" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Sun, Yi Y" , "Wu, Hao" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Yi, On 4/1/20 2:51 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Wednesday, April 1, 2020 4:51 PM >> To: Liu, Yi L ; alex.williamson@redhat.com >> Subject: Re: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to >> userspace >> >> Hi Yi, >> On 3/22/20 1:32 PM, Liu, Yi L wrote: >>> From: Liu Yi L >>> >>> VFIO exposes IOMMU nesting translation (a.k.a dual stage translation) >>> capability to userspace. Thus applications like QEMU could support >>> vIOMMU with hardware's nesting translation capability for pass-through >>> devices. Before setting up nesting translation for pass-through devices, >>> QEMU and other applications need to learn the supported 1st-lvl/stage-1 >>> translation structure format like page table format. >>> >>> Take vSVA (virtual Shared Virtual Addressing) as an example, to support >>> vSVA for pass-through devices, QEMU setup nesting translation for pass- >>> through devices. The guest page table are configured to host as 1st-lvl/ >>> stage-1 page table. Therefore, guest format should be compatible with >>> host side. >>> >>> This patch reports the supported 1st-lvl/stage-1 page table format on the >>> current platform to userspace. QEMU and other alike applications should >>> use this format info when trying to setup IOMMU nesting translation on >>> host IOMMU. >>> >>> Cc: Kevin Tian >>> CC: Jacob Pan >>> Cc: Alex Williamson >>> Cc: Eric Auger >>> Cc: Jean-Philippe Brucker >>> Signed-off-by: Liu Yi L >>> --- >>> drivers/vfio/vfio_iommu_type1.c | 56 >> +++++++++++++++++++++++++++++++++++++++++ >>> include/uapi/linux/vfio.h | 1 + >>> 2 files changed, 57 insertions(+) >>> >>> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >>> index 9aa2a67..82a9e0b 100644 >>> --- a/drivers/vfio/vfio_iommu_type1.c >>> +++ b/drivers/vfio/vfio_iommu_type1.c >>> @@ -2234,11 +2234,66 @@ static int vfio_iommu_type1_pasid_free(struct >> vfio_iommu *iommu, >>> return ret; >>> } >>> >>> +static int vfio_iommu_get_stage1_format(struct vfio_iommu *iommu, >>> + u32 *stage1_format) >> vfio_pasid_format() to be homogeneous with vfio_pgsize_bitmap() which >> does the same kind of enumeration of the vfio_iommu domains > > yes, similar. > >>> +{ >>> + struct vfio_domain *domain; >>> + u32 format = 0, tmp_format = 0; >>> + int ret; >> ret = -EINVAL; > > got it. > >>> + >>> + mutex_lock(&iommu->lock); >>> + if (list_empty(&iommu->domain_list)) { >> goto out_unlock; > > right. >>> + mutex_unlock(&iommu->lock); >>> + return -EINVAL; >>> + } >>> + >>> + list_for_each_entry(domain, &iommu->domain_list, next) { >>> + if (iommu_domain_get_attr(domain->domain, >>> + DOMAIN_ATTR_PASID_FORMAT, &format)) { >> I can find DOMAIN_ATTR_PASID_FORMAT in Jacob's v9 but not in v10 > > oops, I guess he somehow missed. you may find it in below link. > > https://github.com/luxis1999/linux-vsva/commit/bf14b11a12f74d58ad3ee626a5d891de395082eb > >>> + ret = -EINVAL; >> could be removed > > sure. > >>> + format = 0; >>> + goto out_unlock; >>> + } >>> + /* >>> + * format is always non-zero (the first format is >>> + * IOMMU_PASID_FORMAT_INTEL_VTD which is 1). For >>> + * the reason of potential different backed IOMMU >>> + * formats, here we expect to have identical formats >>> + * in the domain list, no mixed formats support. >>> + * return -EINVAL to fail the attempt of setup >>> + * VFIO_TYPE1_NESTING_IOMMU if non-identical formats >>> + * are detected. >>> + */ >>> + if (tmp_format && tmp_format != format) { >>> + ret = -EINVAL; >> could be removed > > got it. > >>> + format = 0; >>> + goto out_unlock; >>> + } >>> + >>> + tmp_format = format; >>> + } >>> + ret = 0; >>> + >>> +out_unlock: >>> + if (format) >> if (!ret) ? then you can remove the format = 0 in case of error. > > oh, yes. > >>> + *stage1_format = format; >>> + mutex_unlock(&iommu->lock); >>> + return ret; >>> +} >>> + >>> static int vfio_iommu_info_add_nesting_cap(struct vfio_iommu *iommu, >>> struct vfio_info_cap *caps) >>> { >>> struct vfio_info_cap_header *header; >>> struct vfio_iommu_type1_info_cap_nesting *nesting_cap; >>> + u32 formats = 0; >>> + int ret; >>> + >>> + ret = vfio_iommu_get_stage1_format(iommu, &formats); >>> + if (ret) { >>> + pr_warn("Failed to get stage-1 format\n"); >> trace triggered by userspace to be removed? > > sure. > >>> + return ret; >>> + } >>> >>> header = vfio_info_cap_add(caps, sizeof(*nesting_cap), >>> VFIO_IOMMU_TYPE1_INFO_CAP_NESTING, 1); >>> @@ -2254,6 +2309,7 @@ static int vfio_iommu_info_add_nesting_cap(struct >> vfio_iommu *iommu, >>> /* nesting iommu type supports PASID requests (alloc/free) */ >>> nesting_cap->nesting_capabilities |= VFIO_IOMMU_PASID_REQS; >> What is the meaning for ARM? > > I think it's just a software capability exposed to userspace, on > userspace side, it has a choice to use it or not. :-) The reason > define it and report it in cap nesting is that I'd like to make > the pasid alloc/free be available just for IOMMU with type > VFIO_IOMMU_TYPE1_NESTING. Please feel free tell me if it is not > good for ARM. We can find a proper way to report the availability. Well it is more a question for jean-Philippe. Do we have a system wide PASID allocation on ARM? Thanks Eric > >>> } >>> + nesting_cap->stage1_formats = formats; >> as spotted by Kevin, since a single format is supported, rename > > ok, I was believing it may be possible on ARM or so. :-) will > rename it. > > I'll refine the patch per your above comments. > > Regards, > Yi Liu > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu