From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org
Subject: Re: [PATCH 1/1] iommu/vt-d: Fix pointer cast warnings on 32 bit
Date: Tue, 19 May 2020 20:41:14 +0800 [thread overview]
Message-ID: <b99ba52c-70bd-79d1-aa15-83deefc42f7d@linux.intel.com> (raw)
In-Reply-To: <20200519120911.GH18353@8bytes.org>
On 2020/5/19 20:09, Joerg Roedel wrote:
> On Tue, May 19, 2020 at 09:34:23AM +0800, Lu Baolu wrote:
>> Pointers should be casted to unsigned long to avoid "cast from pointer
>> to integer of different size" warnings.
>>
>> drivers/iommu/intel-pasid.c:818:6: warning:
>> cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> drivers/iommu/intel-pasid.c:821:9: warning:
>> cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> drivers/iommu/intel-pasid.c:824:23: warning:
>> cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> drivers/iommu/intel-svm.c:343:45: warning:
>> cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>
>> Fixes: d64d47f4f5678 ("iommu/vt-d: Add nested translation helper function")
>> Fixes: a3bea1a35c083 ("iommu/vt-d: Add bind guest PASID support")
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> ---
>> drivers/iommu/intel-pasid.c | 8 ++++----
>> drivers/iommu/intel-svm.c | 3 ++-
>> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> Applied, thanks.
>
> Btw, I think the PASID and Intel SVM code is pretty useless on 32 bit
> anyway, no? It only supports 4 and 5 level page-tables, not the 2 and
> 3-level variants on 32-bit. Can you make it 64-bit only?
Sure. I will make it.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-05-19 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 1:34 [PATCH 1/1] iommu/vt-d: Fix pointer cast warnings on 32 bit Lu Baolu
2020-05-19 12:09 ` Joerg Roedel
2020-05-19 12:41 ` Lu Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99ba52c-70bd-79d1-aa15-83deefc42f7d@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).