From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
Joerg Roedel <joro@8bytes.org>, Steve Wahl <steve.wahl@hpe.com>
Cc: baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Mike Travis <mike.travis@hpe.com>,
Dimitri Sivanich <sivanich@hpe.com>,
"Anderson, Russ" <russ.anderson@hpe.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] iommu/vt-d: Refactor iommu information of each domain
Date: Thu, 7 Jul 2022 10:22:32 +0800 [thread overview]
Message-ID: <c2a378eb-0107-ea10-1b9a-a8bdfd7ec71a@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB52764D1132C2AB21B0A2A1B48C839@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2022/7/7 09:01, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Saturday, July 2, 2022 9:56 AM
>>
>> -out_unlock:
>> + set_bit(num, iommu->domain_ids);
>> + info->refcnt = 1;
>> + info->did = num;
>> + info->iommu = iommu;
>> + domain->nid = iommu->node;
>
> One nit. this line should be removed as it's incorrect to blindly update
> domain->nid and we should just leave to domain_update_iommu_cap()
> to decide the right node. Otherwise this causes a policy conflict as
> here it is the last attached device deciding the node which is different
> from domain_update_iommu_cap() which picks the node of the first
> attached device.
Agreed and updated. Thank you!
>
> Otherwise,
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Best regards,
baolu
next prev parent reply other threads:[~2022-07-07 2:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 1:56 [PATCH v2 0/6] iommu/vt-d: Reset DMAR_UNITS_SUPPORTED Lu Baolu
2022-07-02 1:56 ` Lu Baolu
2022-07-02 1:56 ` [PATCH v2 1/6] iommu/vt-d: Remove unused domain_get_iommu() Lu Baolu
2022-07-02 1:56 ` Lu Baolu
2022-07-02 1:56 ` [PATCH v2 2/6] iommu/vt-d: Use IDA interface to manage iommu sequence id Lu Baolu
2022-07-02 1:56 ` Lu Baolu
2022-07-07 0:53 ` Tian, Kevin
2022-07-02 1:56 ` [PATCH v2 3/6] iommu/vt-d: Refactor iommu information of each domain Lu Baolu
2022-07-02 1:56 ` Lu Baolu
2022-07-07 1:01 ` Tian, Kevin
2022-07-07 2:22 ` Baolu Lu [this message]
2022-07-02 1:56 ` [PATCH v2 4/6] iommu/vt-d: Remove unnecessary check in intel_iommu_add() Lu Baolu
2022-07-02 1:56 ` Lu Baolu
2022-07-07 1:01 ` Tian, Kevin
2022-07-02 1:56 ` [PATCH v2 5/6] iommu/vt-d: Remove global g_iommus array Lu Baolu
2022-07-02 1:56 ` Lu Baolu
2022-07-02 1:56 ` [PATCH v2 6/6] iommu/vt-d: Make DMAR_UNITS_SUPPORTED default 1024 Lu Baolu
2022-07-02 1:56 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a378eb-0107-ea10-1b9a-a8bdfd7ec71a@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=russ.anderson@hpe.com \
--cc=sivanich@hpe.com \
--cc=steve.wahl@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).