From: Markus Elfring <Markus.Elfring@web.de>
To: "Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Jörg Rödel" <joro@8bytes.org>,
iommu@lists.linux-foundation.org
Cc: Kangjie Lu <kjlu@umn.edu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Qiushi Wu <wu000273@umn.edu>
Subject: Re: [PATCH v2] iommu: Improve exception handling in iommu_group_alloc()
Date: Tue, 2 Jun 2020 10:00:13 +0200 [thread overview]
Message-ID: <c6f587ac-aebe-3aae-da0e-087dc7f78ac5@web.de> (raw)
> Improve the exception handling to free the resources correctly when
> failed to allocate an iommu group.
I propose to avoid the specification of duplicate function calls.
Will it become helpful to add a few jump targets?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=f359287765c04711ff54fbd11645271d8e5ff763#n455
> ---
> drivers/iommu/iommu.c | 10 ++++++++--
I suggest to replace the triple dashes before this diffstat
by a blank line.
Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2020-06-02 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 8:00 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-02 2:02 [PATCH v2] iommu: Improve exception handling in iommu_group_alloc() Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f587ac-aebe-3aae-da0e-087dc7f78ac5@web.de \
--to=markus.elfring@web.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).