From: Robin Murphy <robin.murphy@arm.com>
To: "yukuai (C)" <yukuai3@huawei.com>,
joro@8bytes.org, heiko@sntech.de, jeffy.chen@rock-chips.com
Cc: linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com
Subject: Re: [PATCH] iommu/rockchip: check return value of of_find_device_by_node() in rk_iommu_of_xlate()
Date: Thu, 29 Oct 2020 13:51:23 +0000 [thread overview]
Message-ID: <d5442e6b-2a6b-a8f9-2056-2c0c81e88a01@arm.com> (raw)
In-Reply-To: <35ff5111-1270-fc88-788c-4fb9e38faa85@huawei.com>
On 2020-10-29 13:19, yukuai (C) wrote:
>
> On 2020/10/29 18:08, Robin Murphy wrote:
>> On 2020-10-29 09:22, Yu Kuai wrote:
>>> If of_find_device_by_node() failed in rk_iommu_of_xlate(), null pointer
>>> dereference will be triggered. Thus return error code if
>>> of_find_device_by_node() failed.
>>
>> How can that happen? (Given that ".suppress_bind_attrs = true")
>>
>> Robin.
>
> I'm not sure if that could happen...
>
> My thought is that it's better to do such checking to aviod any possible
> problem.
->of_xlate() is only invoked on the specific set of ops returned by
iommu_ops_from_fwnode(). In turn, iommu_ops_from_fwnode() will only
return those ops if the driver has successfully probed and called
iommu_register_device() with the relevant DT node. For the driver to
have been able to probe at all, a platform device associated with that
DT node must have been created, and therefore of_find_device_by_node()
cannot fail.
If there ever were some problem serious enough to break that fundamental
assumption, then I *want* these drivers to crash right here, with a nice
clear stack trace to start debugging from. So no, I firmly disagree that
adding redundant code, which will never do anything except attempt to
paper over catastrophic memory corruption, is "better". Sorry :)
Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-10-29 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 9:22 [PATCH] iommu/rockchip: check return value of of_find_device_by_node() in rk_iommu_of_xlate() Yu Kuai
2020-10-29 10:08 ` Robin Murphy
2020-10-29 13:19 ` yukuai (C)
2020-10-29 13:51 ` Robin Murphy [this message]
2020-10-30 1:27 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5442e6b-2a6b-a8f9-2056-2c0c81e88a01@arm.com \
--to=robin.murphy@arm.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jeffy.chen@rock-chips.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).