From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED90C3A5A0 for ; Mon, 19 Aug 2019 18:10:50 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E61A2087E for ; Mon, 19 Aug 2019 18:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E61A2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3DA3ADD4; Mon, 19 Aug 2019 18:10:50 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 2AD35DC8 for ; Mon, 19 Aug 2019 18:10:49 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id C681D8AB for ; Mon, 19 Aug 2019 18:10:48 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 41286360; Mon, 19 Aug 2019 11:10:48 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3FEC3F246; Mon, 19 Aug 2019 11:10:46 -0700 (PDT) Subject: Re: [PATCH v2 00/17] Arm SMMU refactoring To: Will Deacon References: <20190819155634.xflkhxexzks3y7oa@willie-the-truck> From: Robin Murphy Message-ID: Date: Mon, 19 Aug 2019 19:10:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190819155634.xflkhxexzks3y7oa@willie-the-truck> Content-Language: en-GB Cc: bjorn.andersson@linaro.org, iommu@lists.linux-foundation.org, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Archived-At: List-Archive: On 19/08/2019 16:56, Will Deacon wrote: > On Thu, Aug 15, 2019 at 07:37:20PM +0100, Robin Murphy wrote: >> v1 for context: https://patchwork.kernel.org/cover/11087347/ >> >> Here's a quick v2 attempting to address all the minor comments; I've >> tweaked a whole bunch of names, added some verbosity in macros and >> comments for clarity, and rejigged arm_smmu_impl_init() for a bit more >> structure. The (new) patches #1 and #2 are up front as conceptual fixes, >> although they're not actually critical - it turns out to be more of an >> embarrassment than a real problem in practice. > > Thanks, I'll pick this up and send to Joerg later this week. Oops, I've just noticed that the io-64-nonatomic-hi-lo.h include also needs to move to arm-smmu.h in #14 to avoid breaking 32-bit builds. I've pushed out an updated branch (along with the static fixes for good measure) - let me know if you'd like a resend of the patches. Cheers, Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu