From: Logan Gunthorpe <logang@deltatee.com>
To: Nadav Amit <namit@vmware.com>, Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Fix wrong analysis whether devices share the same bus
Date: Fri, 23 Aug 2019 17:06:34 -0600 [thread overview]
Message-ID: <e0700e76-c8c5-7052-cf17-81cc7ad76d04@deltatee.com> (raw)
In-Reply-To: <20190820085317.29458-1-namit@vmware.com>
On 2019-08-20 2:53 a.m., Nadav Amit wrote:
> set_msi_sid_cb() is used to determine whether device aliases share the
> same bus, but it can provide false indications that aliases use the same
> bus when in fact they do not. The reason is that set_msi_sid_cb()
> assumes that pdev is fixed, while actually pci_for_each_dma_alias() can
> call fn() when pdev is set to a subordinate device.
>
> As a result, running an VM on ESX with VT-d emulation enabled can
> results in the log warning such as:
>
> DMAR: [INTR-REMAP] Request device [00:11.0] fault index 3b [fault reason 38] Blocked an interrupt request due to source-id verification failure
>
> This seems to cause additional ata errors such as:
> ata3.00: qc timeout (cmd 0xa1)
> ata3.00: failed to IDENTIFY (I/O error, err_mask=0x4)
>
> These timeouts also cause boot to be much longer and other errors.
>
> Fix it by checking comparing the alias with the previous one instead.
>
> Fixes: 3f0c625c6ae71 ("iommu/vt-d: Allow interrupts from the entire bus for aliased devices")
> Cc: stable@vger.kernel.org
> Cc: Logan Gunthorpe <logang@deltatee.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Signed-off-by: Nadav Amit <namit@vmware.com>
This looks good to me.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Thanks!
Logan
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-08-23 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 8:53 [PATCH] iommu/vt-d: Fix wrong analysis whether devices share the same bus Nadav Amit via iommu
2019-08-23 23:06 ` Logan Gunthorpe [this message]
2019-08-30 13:48 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0700e76-c8c5-7052-cf17-81cc7ad76d04@deltatee.com \
--to=logang@deltatee.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).