From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE7F4C433E1 for ; Tue, 30 Jun 2020 10:49:40 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C27D72065F for ; Tue, 30 Jun 2020 10:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C27D72065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 8D5F62156E; Tue, 30 Jun 2020 10:49:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3d1fH4g0yuNJ; Tue, 30 Jun 2020 10:49:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id DB24A2107F; Tue, 30 Jun 2020 10:49:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B8D9EC088F; Tue, 30 Jun 2020 10:49:23 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4FFB0C016E for ; Tue, 30 Jun 2020 10:49:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4C2E586786 for ; Tue, 30 Jun 2020 10:49:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OWF9pbYr2TW9 for ; Tue, 30 Jun 2020 10:49:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by whitealder.osuosl.org (Postfix) with ESMTP id 7622C8675F for ; Tue, 30 Jun 2020 10:49:21 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 14FF330E; Tue, 30 Jun 2020 03:49:21 -0700 (PDT) Received: from [10.57.21.32] (unknown [10.57.21.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A7B33F68F; Tue, 30 Jun 2020 03:49:19 -0700 (PDT) Subject: Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA To: Joerg Roedel References: <20200629121146.24011-1-geert@linux-m68k.org> <20200630100947.GL28824@8bytes.org> From: Robin Murphy Message-ID: Date: Tue, 30 Jun 2020 11:49:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200630100947.GL28824@8bytes.org> Content-Language: en-GB Cc: iommu@lists.linux-foundation.org, Geert Uytterhoeven , Maxime Ripard , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2020-06-30 11:09, Joerg Roedel wrote: > On Mon, Jun 29, 2020 at 05:29:36PM +0100, Robin Murphy wrote: >> On 2020-06-29 13:11, Geert Uytterhoeven wrote: >>> If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): >>> >>> drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': >>> dma-iommu.c:(.text+0x92e): undefined reference to `dma_pgprot' >>> >>> IOMMU_DMA must not be selected, unless HAS_DMA=y. >> >> Wait, no, IOMMU_DMA should not be selected by drivers at all - it's for arch >> code to choose. > > Okay, but that is a different fix, right? I queued this patch for v5.8 > for now. If the driver didn't select IOMMU_DMA (completely unnecessarily, I might add), there wouldn't be any problem to fix in the first place ;) Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu