From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A44BC4363A for ; Thu, 29 Oct 2020 07:04:45 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 054F921D6C for ; Thu, 29 Oct 2020 07:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iTVoSTQ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 054F921D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id A883387475; Thu, 29 Oct 2020 07:04:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X8AfLo+8yOOv; Thu, 29 Oct 2020 07:04:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 53FC38739C; Thu, 29 Oct 2020 07:04:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 435C6C0859; Thu, 29 Oct 2020 07:04:41 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91098C0051 for ; Thu, 29 Oct 2020 07:04:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 803B021537 for ; Thu, 29 Oct 2020 07:04:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o42tGxjNqB3P for ; Thu, 29 Oct 2020 07:04:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by silver.osuosl.org (Postfix) with ESMTPS id 5861020479 for ; Thu, 29 Oct 2020 07:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603955077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+MySIa0GO5sAsedbOJklvkP1JxXrpHRlnL4dRpsf/4=; b=iTVoSTQ2NbxX4x11OjpDifcwXh3AsZtz6+oh5Ja5vUOoAK68O27u/E5SSxfUK4zFpggGIL +PSRLDCC5dYbjYzOqHWaQIQBy2yTFGqs1LhdhV9BWpnfNf7SLyXYIsO+3iadojFlFckni5 8MluJPFb80lVt+N1OBRVvpGoncLca/k= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-am_YC9ykM4ODNvViPX-xTg-1; Thu, 29 Oct 2020 03:04:35 -0400 X-MC-Unique: am_YC9ykM4ODNvViPX-xTg-1 Received: by mail-wm1-f69.google.com with SMTP id z7so740489wme.8 for ; Thu, 29 Oct 2020 00:04:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+MySIa0GO5sAsedbOJklvkP1JxXrpHRlnL4dRpsf/4=; b=exJNM0+leYZE57cs+xnVxZZsknddzu0hX4RXUE9d7AvjUuWeSnRgc3FhbmNbuIz8yg tkGakPxLWKykpe8yfO6n+uFxZYlL6JD6/hUdr6SdSy1JY/hdzx3ILSxszt9+oEsI/GIO 5/0Falz8ivO+DGnY3AKzPjYrP3p9LhNHX+NuVujSDzNjW5r+ZQS7uD+PrkJrgmseCuX7 fm0p9dR59tT3hCGgl9NrS/Z8iiXV9GvHXKrAFYXvlRKiu00WTqcTdpZfbkkS7McHIGlc F+Ozdwb2abT3E2ANYj21f7m2Uo34SiSbR0Y0jp9ie6bir+aHxUSVOp30zHPjN70LN9g3 GbiA== X-Gm-Message-State: AOAM531jtFrf6GMd9wZAyN7/y8I5j25OPTqKlZtPWvuniWg2nupP9XeE wJ2TiJ/NbOQHlMzZMxeDmcd23r8lfTrFY4EmDtP9ua/KkEXOkDOZsCWvSUmUWeZQSuyUYTyiAH4 jgtPb8rs6L0Ta3jrsYb3KFBEXjaRQwQ== X-Received: by 2002:adf:e4ca:: with SMTP id v10mr3780267wrm.53.1603955073916; Thu, 29 Oct 2020 00:04:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjtd7rX2GzPMeGPldc12GMpi5saPCqNeQJ2ZCa70evuRQIB96hYYOHQ+JlKqMs5entrVHldQ== X-Received: by 2002:adf:e4ca:: with SMTP id v10mr3780234wrm.53.1603955073729; Thu, 29 Oct 2020 00:04:33 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id 3sm2825527wmd.19.2020.10.29.00.04.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 00:04:33 -0700 (PDT) Subject: Re: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header To: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org References: <20201028212417.3715575-1-arnd@kernel.org> From: Paolo Bonzini Message-ID: Date: Thu, 29 Oct 2020 08:04:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201028212417.3715575-1-arnd@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: linux-hyperv@vger.kernel.org, Stephen Hemminger , kvm@vger.kernel.org, Arnd Bergmann , Haiyang Zhang , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org, "H. Peter Anvin" , Wanpeng Li , Vitaly Kuznetsov , "K. Y. Srinivasan" , Jim Mattson X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 28/10/20 22:20, Arnd Bergmann wrote: > Avoid this by renaming the global 'apic' variable to the more descriptive > 'x86_system_apic'. It was originally called 'genapic', but both that > and the current 'apic' seem to be a little overly generic for a global > variable. The 'apic' affects only the current CPU, so one of 'x86_local_apic', 'x86_lapic' or 'x86_apic' is probably preferrable. I don't have huge objections to renaming 'apic' variables and arguments in KVM to 'lapic'. I do agree with Sean however that it's going to break again very soon. Paolo _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu