From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: liyihang6@hisilicon.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, will@kernel.org
Subject: Re: [RFC PATCH] dma-iommu: Add iommu_dma_max_mapping_size()
Date: Wed, 18 May 2022 14:45:07 +0100 [thread overview]
Message-ID: <f88ea085-2161-02ff-ee36-a004b9e48338@arm.com> (raw)
In-Reply-To: <20220518131237.GA26019@lst.de>
On 2022-05-18 14:12, Christoph Hellwig wrote:
> On Tue, May 17, 2022 at 11:40:52AM +0100, Robin Murphy wrote:
>> Indeed, sorry but NAK for this being nonsense. As I've said at least once
>> before, if the unnecessary SAC address allocation attempt slows down your
>> workload, make it not do that in the first place. If you don't like the
>> existing command-line parameter then fine, there are plenty of other
>> options, it just needs to be done in a way that doesn't break x86 systems
>> with dodgy firmware, as my first attempt turned out to.
>
> What broke x86?
See the thread at [1] (and in case of curiosity the other IVRS patches I
refer to therein were at [2]). Basically, undescribed limitations lead
to DMA address truncation once iommu-dma starts allocating from what it
thinks is the full usable IOVA range. Your typical desktop PC is
unlikely to have enough concurrent DMA-mapped memory to overflow the
32-bit IOVA space naturally, so this has probably been hiding an untold
multitude of sins over the years.
Robin.
[1]
https://lore.kernel.org/linux-iommu/e583fc6dd1fb4ffc90310ff4372ee776f9cc7a3c.1594207679.git.robin.murphy@arm.com/
[2]
https://lore.kernel.org/linux-iommu/20200605145655.13639-1-sebott@amazon.de/
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-05-18 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 13:06 [RFC PATCH] dma-iommu: Add iommu_dma_max_mapping_size() John Garry via iommu
2022-05-17 8:38 ` Christoph Hellwig
2022-05-17 9:02 ` John Garry via iommu
2022-05-17 9:11 ` Christoph Hellwig
2022-05-17 10:40 ` Robin Murphy
2022-05-17 11:26 ` John Garry via iommu
2022-05-17 12:02 ` Robin Murphy
2022-05-17 13:50 ` John Garry via iommu
2022-05-18 13:13 ` Christoph Hellwig
2022-05-20 8:51 ` Joerg Roedel
2022-05-18 13:12 ` Christoph Hellwig
2022-05-18 13:45 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f88ea085-2161-02ff-ee36-a004b9e48338@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyihang6@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).