From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CEBC433B4 for ; Wed, 14 Apr 2021 07:10:32 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87965613C1 for ; Wed, 14 Apr 2021 07:10:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87965613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 47E2384565; Wed, 14 Apr 2021 07:10:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mjSfNYuUS4tp; Wed, 14 Apr 2021 07:10:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id E2EF984576; Wed, 14 Apr 2021 07:10:30 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BE7B6C000C; Wed, 14 Apr 2021 07:10:30 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 24232C000A for ; Wed, 14 Apr 2021 07:10:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 111FB84576 for ; Wed, 14 Apr 2021 07:10:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OV1FMDxt8x3I for ; Wed, 14 Apr 2021 07:10:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp1.osuosl.org (Postfix) with ESMTPS id 073AA84565 for ; Wed, 14 Apr 2021 07:10:27 +0000 (UTC) IronPort-SDR: PD5jUlRxVNDNj6ovQbFycgWcuVn/TNmgJbk9l03trcj2rkpCD1HbzEZNPos88k8RZEW5kpGu6C MBmWdeZQnA6w== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="194694528" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="194694528" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 00:10:24 -0700 IronPort-SDR: LPDjYvTHctJbm+V68V9IjOOQKtLJ4OlSdGwjd/itmDlxHu/E+zSqwp2lC/nxkazMLe8s5chtuL h5Ri1FnE60Ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="443716342" Received: from allen-box.sh.intel.com (HELO [10.239.159.128]) ([10.239.159.128]) by fmsmga004.fm.intel.com with ESMTP; 14 Apr 2021 00:10:19 -0700 Subject: Re: [PATCH v3 01/12] iommu: Introduce dirty log tracking framework To: Keqian Zhu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Robin Murphy , Will Deacon , Joerg Roedel , Yi Sun , Jean-Philippe Brucker , Jonathan Cameron , Tian Kevin References: <20210413085457.25400-1-zhukeqian1@huawei.com> <20210413085457.25400-2-zhukeqian1@huawei.com> From: Lu Baolu Message-ID: Date: Wed, 14 Apr 2021 15:00:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210413085457.25400-2-zhukeqian1@huawei.com> Content-Language: en-US Cc: jiangkunkun@huawei.com, Cornelia Huck , Kirti Wankhede , lushenming@huawei.com, Alex Williamson , wanghaibin.wang@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Keqian, On 4/13/21 4:54 PM, Keqian Zhu wrote: > Some types of IOMMU are capable of tracking DMA dirty log, such as > ARM SMMU with HTTU or Intel IOMMU with SLADE. This introduces the > dirty log tracking framework in the IOMMU base layer. > > Three new essential interfaces are added, and we maintaince the status > of dirty log tracking in iommu_domain. > 1. iommu_switch_dirty_log: Perform actions to start|stop dirty log tracking > 2. iommu_sync_dirty_log: Sync dirty log from IOMMU into a dirty bitmap > 3. iommu_clear_dirty_log: Clear dirty log of IOMMU by a mask bitmap > > A new dev feature are added to indicate whether a specific type of > iommu hardware supports and its driver realizes them. > > Signed-off-by: Keqian Zhu > Signed-off-by: Kunkun Jiang > --- > drivers/iommu/iommu.c | 150 ++++++++++++++++++++++++++++++++++++++++++ > include/linux/iommu.h | 53 +++++++++++++++ > 2 files changed, 203 insertions(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index d0b0a15dba84..667b2d6d2fc0 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1922,6 +1922,7 @@ static struct iommu_domain *__iommu_domain_alloc(struct bus_type *bus, > domain->type = type; > /* Assume all sizes by default; the driver may override this later */ > domain->pgsize_bitmap = bus->iommu_ops->pgsize_bitmap; > + mutex_init(&domain->switch_log_lock); > > return domain; > } > @@ -2720,6 +2721,155 @@ int iommu_domain_set_attr(struct iommu_domain *domain, > } > EXPORT_SYMBOL_GPL(iommu_domain_set_attr); > > +int iommu_switch_dirty_log(struct iommu_domain *domain, bool enable, > + unsigned long iova, size_t size, int prot) > +{ > + const struct iommu_ops *ops = domain->ops; > + int ret; > + > + if (unlikely(!ops || !ops->switch_dirty_log)) > + return -ENODEV; > + > + mutex_lock(&domain->switch_log_lock); > + if (enable && domain->dirty_log_tracking) { > + ret = -EBUSY; > + goto out; > + } else if (!enable && !domain->dirty_log_tracking) { > + ret = -EINVAL; > + goto out; > + } > + > + ret = ops->switch_dirty_log(domain, enable, iova, size, prot); > + if (ret) > + goto out; > + > + domain->dirty_log_tracking = enable; > +out: > + mutex_unlock(&domain->switch_log_lock); > + return ret; > +} > +EXPORT_SYMBOL_GPL(iommu_switch_dirty_log); Since you also added IOMMU_DEV_FEAT_HWDBM, I am wondering what's the difference between iommu_switch_dirty_log(on) vs. iommu_dev_enable_feature(IOMMU_DEV_FEAT_HWDBM) iommu_switch_dirty_log(off) vs. iommu_dev_disable_feature(IOMMU_DEV_FEAT_HWDBM) > + > +int iommu_sync_dirty_log(struct iommu_domain *domain, unsigned long iova, > + size_t size, unsigned long *bitmap, > + unsigned long base_iova, unsigned long bitmap_pgshift) > +{ > + const struct iommu_ops *ops = domain->ops; > + unsigned int min_pagesz; > + size_t pgsize; > + int ret = 0; > + > + if (unlikely(!ops || !ops->sync_dirty_log)) > + return -ENODEV; > + > + min_pagesz = 1 << __ffs(domain->pgsize_bitmap); > + if (!IS_ALIGNED(iova | size, min_pagesz)) { > + pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n", > + iova, size, min_pagesz); > + return -EINVAL; > + } > + > + mutex_lock(&domain->switch_log_lock); > + if (!domain->dirty_log_tracking) { > + ret = -EINVAL; > + goto out; > + } > + > + while (size) { > + pgsize = iommu_pgsize(domain, iova, size); > + > + ret = ops->sync_dirty_log(domain, iova, pgsize, > + bitmap, base_iova, bitmap_pgshift); Any reason why do you want to do this in a per-4K page manner? This can lead to a lot of indirect calls and bad performance. How about a sync_dirty_pages()? The same comment applies to other places in this patch series. > + if (ret) > + break; > + > + pr_debug("dirty_log_sync handle: iova 0x%lx pagesz 0x%zx\n", > + iova, pgsize); > + > + iova += pgsize; > + size -= pgsize; > + } > +out: > + mutex_unlock(&domain->switch_log_lock); > + return ret; > +} > +EXPORT_SYMBOL_GPL(iommu_sync_dirty_log); > + > +static int __iommu_clear_dirty_log(struct iommu_domain *domain, > + unsigned long iova, size_t size, > + unsigned long *bitmap, > + unsigned long base_iova, > + unsigned long bitmap_pgshift) > +{ > + const struct iommu_ops *ops = domain->ops; > + size_t pgsize; > + int ret = 0; > + > + if (unlikely(!ops || !ops->clear_dirty_log)) > + return -ENODEV; > + > + while (size) { > + pgsize = iommu_pgsize(domain, iova, size); > + > + ret = ops->clear_dirty_log(domain, iova, pgsize, bitmap, > + base_iova, bitmap_pgshift); > + if (ret) > + break; > + > + pr_debug("dirty_log_clear handled: iova 0x%lx pagesz 0x%zx\n", > + iova, pgsize); > + > + iova += pgsize; > + size -= pgsize; > + } > + > + return ret; > +} > + > +int iommu_clear_dirty_log(struct iommu_domain *domain, > + unsigned long iova, size_t size, > + unsigned long *bitmap, unsigned long base_iova, > + unsigned long bitmap_pgshift) > +{ > + unsigned long riova, rsize; > + unsigned int min_pagesz; > + bool flush = false; > + int rs, re, start, end; > + int ret = 0; > + > + min_pagesz = 1 << __ffs(domain->pgsize_bitmap); > + if (!IS_ALIGNED(iova | size, min_pagesz)) { > + pr_err("unaligned: iova 0x%lx min_pagesz 0x%x\n", > + iova, min_pagesz); > + return -EINVAL; > + } > + > + mutex_lock(&domain->switch_log_lock); > + if (!domain->dirty_log_tracking) { > + ret = -EINVAL; > + goto out; > + } > + > + start = (iova - base_iova) >> bitmap_pgshift; > + end = start + (size >> bitmap_pgshift); > + bitmap_for_each_set_region(bitmap, rs, re, start, end) { > + flush = true; > + riova = iova + (rs << bitmap_pgshift); > + rsize = (re - rs) << bitmap_pgshift; > + ret = __iommu_clear_dirty_log(domain, riova, rsize, bitmap, > + base_iova, bitmap_pgshift); > + if (ret) > + break; > + } > + > + if (flush) > + iommu_flush_iotlb_all(domain); > +out: > + mutex_unlock(&domain->switch_log_lock); > + return ret; > +} > +EXPORT_SYMBOL_GPL(iommu_clear_dirty_log); > + > void iommu_get_resv_regions(struct device *dev, struct list_head *list) > { > const struct iommu_ops *ops = dev->bus->iommu_ops; > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 5e7fe519430a..7f9ed9f520e2 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -87,6 +87,8 @@ struct iommu_domain { > void *handler_token; > struct iommu_domain_geometry geometry; > void *iova_cookie; > + bool dirty_log_tracking; > + struct mutex switch_log_lock; > }; > > enum iommu_cap { > @@ -160,6 +162,7 @@ struct iommu_resv_region { > enum iommu_dev_features { > IOMMU_DEV_FEAT_AUX, /* Aux-domain feature */ > IOMMU_DEV_FEAT_SVA, /* Shared Virtual Addresses */ > + IOMMU_DEV_FEAT_HWDBM, /* Hardware Dirty Bit Management */ > }; > > #define IOMMU_PASID_INVALID (-1U) > @@ -205,6 +208,9 @@ struct iommu_iotlb_gather { > * @device_group: find iommu group for a particular device > * @domain_get_attr: Query domain attributes > * @domain_set_attr: Change domain attributes > + * @switch_dirty_log: Perform actions to start|stop dirty log tracking > + * @sync_dirty_log: Sync dirty log from IOMMU into a dirty bitmap > + * @clear_dirty_log: Clear dirty log of IOMMU by a mask bitmap > * @get_resv_regions: Request list of reserved regions for a device > * @put_resv_regions: Free list of reserved regions for a device > * @apply_resv_region: Temporary helper call-back for iova reserved ranges > @@ -260,6 +266,18 @@ struct iommu_ops { > int (*domain_set_attr)(struct iommu_domain *domain, > enum iommu_attr attr, void *data); > > + /* Track dirty log */ > + int (*switch_dirty_log)(struct iommu_domain *domain, bool enable, > + unsigned long iova, size_t size, int prot); > + int (*sync_dirty_log)(struct iommu_domain *domain, > + unsigned long iova, size_t size, > + unsigned long *bitmap, unsigned long base_iova, > + unsigned long bitmap_pgshift); > + int (*clear_dirty_log)(struct iommu_domain *domain, > + unsigned long iova, size_t size, > + unsigned long *bitmap, unsigned long base_iova, > + unsigned long bitmap_pgshift); > + > /* Request/Free a list of reserved regions for a device */ > void (*get_resv_regions)(struct device *dev, struct list_head *list); > void (*put_resv_regions)(struct device *dev, struct list_head *list); > @@ -511,6 +529,16 @@ extern int iommu_domain_get_attr(struct iommu_domain *domain, enum iommu_attr, > void *data); > extern int iommu_domain_set_attr(struct iommu_domain *domain, enum iommu_attr, > void *data); > +extern int iommu_switch_dirty_log(struct iommu_domain *domain, bool enable, > + unsigned long iova, size_t size, int prot); > +extern int iommu_sync_dirty_log(struct iommu_domain *domain, unsigned long iova, > + size_t size, unsigned long *bitmap, > + unsigned long base_iova, > + unsigned long bitmap_pgshift); > +extern int iommu_clear_dirty_log(struct iommu_domain *domain, unsigned long iova, > + size_t dma_size, unsigned long *bitmap, > + unsigned long base_iova, > + unsigned long bitmap_pgshift); > > /* Window handling function prototypes */ > extern int iommu_domain_window_enable(struct iommu_domain *domain, u32 wnd_nr, > @@ -901,6 +929,31 @@ static inline int iommu_domain_set_attr(struct iommu_domain *domain, > return -EINVAL; > } > > +static inline int iommu_switch_dirty_log(struct iommu_domain *domain, > + bool enable, unsigned long iova, > + size_t size, int prot) > +{ > + return -EINVAL; > +} > + > +static inline int iommu_sync_dirty_log(struct iommu_domain *domain, > + unsigned long iova, size_t size, > + unsigned long *bitmap, > + unsigned long base_iova, > + unsigned long pgshift) > +{ > + return -EINVAL; > +} > + > +static inline int iommu_clear_dirty_log(struct iommu_domain *domain, > + unsigned long iova, size_t size, > + unsigned long *bitmap, > + unsigned long base_iova, > + unsigned long pgshift) > +{ > + return -EINVAL; > +} > + > static inline int iommu_device_register(struct iommu_device *iommu) > { > return -ENODEV; > Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu