From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fr1.as29.net ([62.210.131.231]:52002 "EHLO toothrot.meleeweb.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbaHPS75 (ORCPT ); Sat, 16 Aug 2014 14:59:57 -0400 From: Bertrand Jacquin Subject: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install Date: Sat, 16 Aug 2014 20:50:14 +0200 Message-Id: <1408215016-1848-2-git-send-email-beber@meleeweb.net> In-Reply-To: <1408215016-1848-1-git-send-email-beber@meleeweb.net> References: <1408215016-1848-1-git-send-email-beber@meleeweb.net> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Rusty Russell , linux-kbuild@vger.kernel.org Cc: Bertrand Jacquin , linux-kernel@vger.kernel.org, Willy Tarreau Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir and cp ? Reviewed-by: Willy Tarreau Signed-off-by: Bertrand Jacquin --- scripts/Makefile.modinst | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index 95ec7b3..aa911b5 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -18,7 +18,11 @@ __modinst: $(modules) # Don't stop modules_install if we can't sign external modules. quiet_cmd_modules_install = INSTALL $@ - cmd_modules_install = mkdir -p $(2); cp $@ $(2) ; $(mod_strip_cmd) $(2)/$(notdir $@) ; $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) + cmd_modules_install = \ + mkdir -p $(2) ; \ + cp $@ $(2) ; \ + $(mod_strip_cmd) $(2)/$(notdir $@) ; \ + $(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) # Modules built outside the kernel source tree go into extra by default INSTALL_MOD_DIR ?= extra -- 2.0.4