[PATCH] kbuild: use mixed-targets when two or more config targets are given

[PATCH] kbuild: use mixed-targets when two or more config targets are given

[Masahiro Yamada]

"make kvmconfig" expects that the .config has already been created,
but some people might want to create the .config and run kvmconfig
in one shot command, like this:

  $ make defconfig kvmconfig

To make sure this command works correctly even if -j* option is set,
we must handle them one by one.
This commit turns on mixed-targets when $(MAKECMDGOALS) includes
at least one config target and also includes another target.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index d9af2be..3272609 100644
--- a/Makefile
+++ b/Makefile
@@ -500,7 +500,7 @@ endif
 ifeq ($(KBUILD_EXTMOD),)
         ifneq ($(filter config %config,$(MAKECMDGOALS)),)
                 config-targets := 1
-                ifneq ($(filter-out config %config,$(MAKECMDGOALS)),)
+                ifneq ($(words $(MAKECMDGOALS)),1)
                         mixed-targets := 1
                 endif
         endif
-- 
1.9.1

Re: [PATCH] kbuild: use mixed-targets when two or more config targets are given

[Michal Marek]

On 2014-12-11 11:12, Masahiro Yamada wrote:
> "make kvmconfig" expects that the .config has already been created,
> but some people might want to create the .config and run kvmconfig
> in one shot command, like this:
> 
>   $ make defconfig kvmconfig
> 
> To make sure this command works correctly even if -j* option is set,
> we must handle them one by one.
> This commit turns on mixed-targets when $(MAKECMDGOALS) includes
> at least one config target and also includes another target.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Applied to kbuild.git#kbuild, thanks.

Michal