Re: [PATCH 2/2] kconfig: Do not print status messages in make -s mode

[Paul Bolle <pebolle@tiscali.nl>]

On Thu, 2015-04-09 at 14:58 +0200, Michal Marek wrote:
> On 2015-04-09 14:47, Paul Bolle wrote:
> > The patch adds this :
> >     conf_set_message_callback(NULL);
> > 
> > for conf, gconf, and qconf. That won't work for mconf?
> 
> Have you tried looking at the mconf code? It sets a message callback to
> display ncurses dialogs.

I see.

mconf sets that callback after it has already done a few things. So
"make -s menuconfig" without a .config will do
    main()
        conf_read(NULL)
            conf_read_simple([...])
                conf_message(_("using defaults found in %s"), [...])
                     conf_message_callback()

and at that point conf_message_callback() still points to
conf_default_message_callback(). This default uses stdout. So I think I
stumbled on a cornercase where one message still can be printed to
stdout. Shocking!

Neither conf nor gconf or qconf (assuming GTK and Qt are silent, that
is) seem to do anything serious before setting that callback, so I don't
expect there to be more messages that can break the silence.

Thanks,


Paul Bolle