From: Shu Wang <shuwang@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: yamada masahiro <yamada.masahiro@socionext.com>,
mmarek@suse.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, chuhu@redhat.com,
yizhan@redhat.com
Subject: Re: [PATCH] kbuild/mkspec: remove firmware from rpm package
Date: Wed, 20 Sep 2017 02:39:01 -0400 (EDT) [thread overview]
Message-ID: <1542341479.7952083.1505889541234.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170920061012.GA32032@kroah.com>
Hi
Do you mean the patch for deb package? The patch didn't fix rpm
package. or there's another patch I didn't get on the mailing list.
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1492398.html
Thanks
----- Original Message -----
> From: "Greg KH" <gregkh@linuxfoundation.org>
> To: shuwang@redhat.com
> Cc: "yamada masahiro" <yamada.masahiro@socionext.com>, mmarek@suse.com, linux-kbuild@vger.kernel.org,
> linux-kernel@vger.kernel.org, chuhu@redhat.com, yizhan@redhat.com
> Sent: Wednesday, September 20, 2017 2:10:12 PM
> Subject: Re: [PATCH] kbuild/mkspec: remove firmware from rpm package
>
> On Wed, Sep 20, 2017 at 10:35:29AM +0800, shuwang@redhat.com wrote:
> > From: Shu Wang <shuwang@redhat.com>
> >
> > Commit 5620a0d1aacd ("firmware: delete in-kernel firmware") deleted
> > in-kernel firmware support, including the firmware install command.
> >
> > So make binrpm-pkg will failed as no firmware_install make target.
> >
> > Signed-off-by: Shu Wang <shuwang@redhat.com>
> > ---
> > scripts/package/mkspec | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> > index bb43f153fd8e..8f34e31d8474 100755
> > --- a/scripts/package/mkspec
> > +++ b/scripts/package/mkspec
> > @@ -88,11 +88,8 @@ echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi
> > $RPM_BUILD_ROOT/lib/modules'
> > echo "%else"
> > echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
> > echo "%endif"
> > -echo 'mkdir -p $RPM_BUILD_ROOT'"/lib/firmware/$KERNELRELEASE"
> >
> > echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{?_smp_mflags} KBUILD_SRC=
> > mod-fw= modules_install'
> > -echo 'INSTALL_FW_PATH=$RPM_BUILD_ROOT'"/lib/firmware/$KERNELRELEASE"
> > -echo 'make INSTALL_FW_PATH=$INSTALL_FW_PATH' firmware_install
> > echo "%ifarch ia64"
> > echo 'cp $KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/efi/vmlinuz-$KERNELRELEASE"
> > echo 'ln -s '"efi/vmlinuz-$KERNELRELEASE" '$RPM_BUILD_ROOT'"/boot/"
> > @@ -154,7 +151,6 @@ echo '%defattr (-, root, root)'
> > echo "/lib/modules/$KERNELRELEASE"
> > echo "%exclude /lib/modules/$KERNELRELEASE/build"
> > echo "%exclude /lib/modules/$KERNELRELEASE/source"
> > -echo "/lib/firmware/$KERNELRELEASE"
> > echo "/boot/*"
> > echo ""
> > echo "%files headers"
>
> I think this has already been posted to the list, right?
>
> Sorry about it, it's pretty obvious that no build system tests kernel
> packages, and neither do I :)
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2017-09-20 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 2:35 [PATCH] kbuild/mkspec: remove firmware from rpm package shuwang
2017-09-20 6:10 ` Greg KH
2017-09-20 6:39 ` Shu Wang [this message]
2017-09-20 6:55 ` Masahiro Yamada
2017-09-20 7:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542341479.7952083.1505889541234.JavaMail.zimbra@redhat.com \
--to=shuwang@redhat.com \
--cc=chuhu@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).