From: Randy Dunlap <rdunlap@infradead.org>
To: Jurica Vukadin <jura@vukad.in>, Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: Update config changed flag before calling callback
Date: Sun, 12 Mar 2023 20:15:40 -0700 [thread overview]
Message-ID: <1c308360-a820-26ed-847c-56726afe0ec3@infradead.org> (raw)
In-Reply-To: <20230307194039.8825-1-jura@vukad.in>
Hi--
On 3/7/23 11:40, Jurica Vukadin wrote:
> Prior to commit 5ee546594025 ("kconfig: change sym_change_count to a
> boolean flag"), the conf_updated flag was set to the new value *before*
> calling the callback. xconfig's save action depends on this behaviour,
> because xconfig calls conf_get_changed() directly from the callback and
> now sees the old value, thus never enabling the save button or the
> shortcut.
>
> Restore the previous behaviour.
>
> Fixes: 5ee546594025 ("kconfig: change sym_change_count to a boolean flag")
> Signed-off-by: Jurica Vukadin <jura@vukad.in>
Thanks! I was wondering what had happened to that, but I never
got around to bisecting it.
Now the Disk icon is live instead of being greyed out after
a change is made.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> scripts/kconfig/confdata.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index b7c9f1dd5e42..992575f1e976 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -1226,10 +1226,12 @@ static void (*conf_changed_callback)(void);
>
> void conf_set_changed(bool val)
> {
> - if (conf_changed_callback && conf_changed != val)
> - conf_changed_callback();
> + bool changed = conf_changed != val;
>
> conf_changed = val;
> +
> + if (conf_changed_callback && changed)
> + conf_changed_callback();
> }
>
> bool conf_get_changed(void)
--
~Randy
next prev parent reply other threads:[~2023-03-13 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 19:40 [PATCH] kconfig: Update config changed flag before calling callback Jurica Vukadin
2023-03-13 3:15 ` Randy Dunlap [this message]
2023-03-13 18:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c308360-a820-26ed-847c-56726afe0ec3@infradead.org \
--to=rdunlap@infradead.org \
--cc=jura@vukad.in \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).