Linux-KBuild Archive on lore.kernel.org
 help / color / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/3] KBUILD: Add script to manipulate .config files on the command line
Date: Wed, 7 Jan 2009 22:33:15 +0100
Message-ID: <20090107213315.GN496@one.firstfloor.org> (raw)
In-Reply-To: <20090107201849.GH4647@uranus.ravnborg.org>

> When I try to run the script with no arguments nothing happens!?!
> 
> I will merge as is but please followup with a patch so it prints out usage
> in this situation.

Here's a patch 

-Andi

---

Kbuild: print usage with no arguments in scripts/config

Requested by Sam.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 scripts/config |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux-2.6.28-kbuild/scripts/config
===================================================================
--- linux-2.6.28-kbuild.orig/scripts/config	2009-01-02 02:56:55.000000000 +0100
+++ linux-2.6.28-kbuild/scripts/config	2009-01-07 22:17:40.000000000 +0100
@@ -60,6 +60,10 @@
 	FN=.config
 fi
 
+if [ "$1" = "" ] ; then
+	usage
+fi
+
 while [ "$1" != "" ] ; do
 	CMD="$1"
 	shift

-- 
ak@linux.intel.com

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-03  2:21 Andi Kleen
2009-01-03  2:21 ` [PATCH] [2/3] KBUILD: Add a symlink to the source for separate objdirs Andi Kleen
2009-01-07 20:29   ` Sam Ravnborg
2009-01-03  2:21 ` [PATCH] [3/3] KBUILD: Add a "bin" symlink for the scripts directory too Andi Kleen
2009-01-07 20:27   ` Sam Ravnborg
2009-01-07 21:30     ` Andi Kleen
2009-01-07 21:36       ` Sam Ravnborg
2009-01-03 10:54 ` [PATCH] [1/3] KBUILD: Add script to manipulate .config files on the command line Arnd Bergmann
2009-01-03 17:12   ` Andi Kleen
2009-01-07 20:18 ` Sam Ravnborg
2009-01-07 21:33   ` Andi Kleen [this message]
2009-01-07 22:07     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090107213315.GN496@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-KBuild Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kbuild/0 linux-kbuild/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kbuild linux-kbuild/ https://lore.kernel.org/linux-kbuild \
		linux-kbuild@vger.kernel.org
	public-inbox-index linux-kbuild

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kbuild


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git