From: Kyle McMartin <kyle@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: sam@ravnborg.org, jakub@redhat.com, linux-kbuild@vger.kernel.org
Subject: [PATCH] scripts/unifdef.c: rename getline symbol to something else
Date: Wed, 11 Mar 2009 12:17:33 -0400 [thread overview]
Message-ID: <20090311161733.GE5448@bombadil.infradead.org> (raw)
From: Kyle McMartin <kyle@redhat.com>
Rawhide builds are currently failing to build unifdef.c, as the next
version of glibc changes the default _POSIX_C_SOURCE level, which
exposes getline() from <stdio.h>
scripts/unifdef.c:209: error: conflicting types for 'getline'
/usr/include/stdio.h:653: note: previous declaration of 'getline' was
here
make[2]: *** [scripts/unifdef] Error 1
make[1]: *** [__headers] Error 2
make: *** [vmlinux] Error 2
Rename the symbol in unifdef.c to parseline to avoid this conflicting
declaration.
Otherwise Jakub says we could add a -D_POSIX_C_SOURCE=200112L as a
workaround to unifdef CFLAGS, but this seems like it would be less
desirable in the long term.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
diff --git a/scripts/unifdef.c b/scripts/unifdef.c
index 552025e..977e682 100644
--- a/scripts/unifdef.c
+++ b/scripts/unifdef.c
@@ -206,7 +206,7 @@ static void done(void);
static void error(const char *);
static int findsym(const char *);
static void flushline(bool);
-static Linetype getline(void);
+static Linetype parseline(void);
static Linetype ifeval(const char **);
static void ignoreoff(void);
static void ignoreon(void);
@@ -512,7 +512,7 @@ process(void)
for (;;) {
linenum++;
- lineval = getline();
+ lineval = parseline();
trans_table[ifstate[depth]][lineval]();
debug("process %s -> %s depth %d",
linetype_name[lineval],
@@ -526,7 +526,7 @@ process(void)
* help from skipcomment().
*/
static Linetype
-getline(void)
+parseline(void)
{
const char *cp;
int cursym;
next reply other threads:[~2009-03-11 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 16:17 Kyle McMartin [this message]
2009-03-11 18:37 ` [PATCH] scripts/unifdef.c: rename getline symbol to something else Sam Ravnborg
2009-03-11 18:59 ` Kyle McMartin
2009-03-12 6:56 ` Andrew Morton
2009-03-13 5:52 ` Sam Ravnborg
2009-03-13 5:51 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311161733.GE5448@bombadil.infradead.org \
--to=kyle@infradead.org \
--cc=jakub@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).