linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Yann Droneaud <ydroneaud@opteya.com>
Cc: linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	Michal Marek <mmarek@suse.cz>,
	David Woodhouse <dwmw2@infradead.org>,
	Rob Landley <rob@landley.net>
Subject: Re: [PATCHv1 2/2] Documentation/kbuild/headers_install.txt: update documentation
Date: Sun, 13 Jul 2014 23:26:08 +0200	[thread overview]
Message-ID: <20140713212608.GB16496@ravnborg.org> (raw)
In-Reply-To: <3e0d73d0ca3ead75624b552105ce8adf3d63684e.1405246009.git.ydroneaud@opteya.com>

On Sun, Jul 13, 2014 at 12:15:30PM +0200, Yann Droneaud wrote:
> Documentation in kbuild/headers_install.txt is not
> up to date regarding:
> - way to list the various architectures;
> - path where the headers are installed.
> 
> This patch try to fix these issues.
> 
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Rob Landley <rob@landley.net>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
> ---
>  Documentation/kbuild/headers_install.txt | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
> index 951eb9f1e040..8b6751f10dd3 100644
> --- a/Documentation/kbuild/headers_install.txt
> +++ b/Documentation/kbuild/headers_install.txt
> @@ -24,23 +24,24 @@ The "make headers_install" command can be run in the top level directory of the
>  kernel source code (or using a standard out-of-tree build).  It takes two
>  optional arguments:
>  
> -  make headers_install ARCH=i386 INSTALL_HDR_PATH=/usr/include
> +  make headers_install ARCH=i386 INSTALL_HDR_PATH=/usr
OK

>  

> to see a list of supported architectures use
>  the command:
>  
> -  ls -d include/asm-* | sed 's/.*-//'
> +  /bin/ls -1 arch/*/include/asm/Kbuild | sed -e 's,^arch/,,' \
> +                                             -e 's,/include/asm/Kbuild$,,'
This information is nor relevant these days as all architectures support exporting userspace headers.
So drop this part of the documentation.
cris is broken - I will send a patch to fix this.
In reality um does not support exporting headers - but it makes no sense either.
We do not want to do anything special just to mention that um is not included.

>  The command "make headers_install_all" exports headers for all architectures
>  simultaneously.  (This is mostly of interest to distribution maintainers,
>  who create an architecture-independent tarball from the resulting include
>  directory.)
I have seriously considered dropping the "headers_install_all" target.
It does not make any sense as some files are optional for the individual archs
and only pure luck will define if the relevant fiels are included or not.

We would still like the "headers_check_all" feature but this is better done in
a small shell script than as it is today where we need special handling
to support it in Makefile.headersinst - and it adds complexity
to the top-level Makefile which we shall avoid.
But this is unrelated to your documentation clean-up.

	Sam

      reply	other threads:[~2014-07-13 21:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 19:11 [PATCH] Documentation/make/headers_install.txt: update documentation Yann Droneaud
2014-07-03 21:12 ` Michal Marek
2014-07-09 20:49   ` Sam Ravnborg
2014-07-13 10:15     ` [PATCHv1 0/2] Documentation: move and update headers_install.txt Yann Droneaud
2014-07-13 10:15     ` [PATCHv1 1/2] Documentation: headers_install.txt is part of kbuild Yann Droneaud
2014-07-13 21:18       ` Sam Ravnborg
2014-08-05 14:08         ` Michal Marek
2014-07-13 10:15     ` [PATCHv1 2/2] Documentation/kbuild/headers_install.txt: update documentation Yann Droneaud
2014-07-13 21:26       ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140713212608.GB16496@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dwmw2@infradead.org \
    --cc=kirill@shutemov.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rob@landley.net \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).