From: Sam Ravnborg <sam@ravnborg.org>
To: "Vinícius Tinti" <viniciustinti@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Behan Webster <behanw@converseincode.com>
Subject: Re: [PATCH] kbuild: add support to generate LLVM bitcode files
Date: Sun, 20 Jul 2014 23:30:26 +0200 [thread overview]
Message-ID: <20140720213025.GA5103@ravnborg.org> (raw)
In-Reply-To: <20140720210458.GA5019@ravnborg.org>
On Sun, Jul 20, 2014 at 11:04:58PM +0200, Sam Ravnborg wrote:
> > >
> > > +ifeq ($(COMPILER),clang)
> > > +quiet_cmd_cc_ll_c = CC $(quiet_modtag) $@
> > > +cmd_cc_ll_c = $(CC) $(c_flags) $(DISABLE_LTO) -fverbose-asm -emit-llvm -S -o $@ $<
> >
> > Can we drop the test for COMPILER here too?
> > Do -fverbose-asm make sense when generating .ll files?
> > It looks like a leftover from what you copied.
>
> Also $(DISABLE_LTO) looks like a left-over.
> It was added to avoid LTO when generating asm-offstes.s which
> the original rule is also used for.
> So this should be skipped too.
Third thing.
In some places we indent the assignmnet like this:
quiet_cmd_cc_ll_c = CC $(quiet_modtag) $@
cmd_cc_ll_c = $(CC) $(c_flags) ....
This makes it more obvious that the "cmd_cc_ll_c" is actually the same.
Makefile.build does not do this much but please do for these targets.
Sam
next prev parent reply other threads:[~2014-07-20 21:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 1:34 [PATCH] kbuild: add support to generate LLVM bitcode files Vinícius Tinti
2014-07-20 10:02 ` Sam Ravnborg
2014-07-20 21:04 ` Sam Ravnborg
2014-07-20 21:30 ` Sam Ravnborg [this message]
2014-07-21 22:42 ` Tinti
2014-07-22 0:35 ` Sam Ravnborg
2014-07-23 11:56 ` [PATCH v2] " Vinícius Tinti
2014-07-23 12:00 ` Tinti
2014-09-11 23:13 ` [PATCH v3] " Vinícius Tinti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140720213025.GA5103@ravnborg.org \
--to=sam@ravnborg.org \
--cc=behanw@converseincode.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=viniciustinti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).