* [PATCH] dtbsinstall: don't move target directory out of the way
[not found] <20150328132320.GA24391@n2100.arm.linux.org.uk>
@ 2015-03-28 13:37 ` Russell King
2015-03-28 15:59 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Russell King @ 2015-03-28 13:37 UTC (permalink / raw)
To: torvalds, Grant Likely, Rob Herring, Jason Cooper
Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell,
Stephen Warren, Olof Johansson, linux-arm-kernel, Michal Marek,
linux-kbuild
No other kernel installation target moves the target directory out of
the way, even deleting an old version of it. These are destructive
operations, ones which the kernel build system should not be making.
Remove this behaviour.
If this behaviour is required at installation time, this should be
done by the installation external to the kernel makefiles, just like
it would be done for 'make modules_install'.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
scripts/Makefile.dtbinst | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
index 909ed7a2ac61..e0254058b0e9 100644
--- a/scripts/Makefile.dtbinst
+++ b/scripts/Makefile.dtbinst
@@ -23,8 +23,6 @@ include $(srctree)/$(obj)/Makefile
PHONY += __dtbs_install_prep
__dtbs_install_prep:
ifeq ("$(dtbinst-root)", "$(obj)")
- $(Q)if [ -d $(INSTALL_DTBS_PATH).old ]; then rm -rf $(INSTALL_DTBS_PATH).old; fi
- $(Q)if [ -d $(INSTALL_DTBS_PATH) ]; then mv $(INSTALL_DTBS_PATH) $(INSTALL_DTBS_PATH).old; fi
$(Q)mkdir -p $(INSTALL_DTBS_PATH)
endif
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dtbsinstall: don't move target directory out of the way
2015-03-28 13:37 ` [PATCH] dtbsinstall: don't move target directory out of the way Russell King
@ 2015-03-28 15:59 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2015-03-28 15:59 UTC (permalink / raw)
To: Russell King
Cc: torvalds, Grant Likely, Rob Herring, Mark Rutland, devicetree,
Pawel Moll, Ian Campbell, Stephen Warren, Olof Johansson,
linux-arm-kernel, Michal Marek, linux-kbuild
On Sat, Mar 28, 2015 at 01:37:19PM +0000, Russell King wrote:
> No other kernel installation target moves the target directory out of
> the way, even deleting an old version of it. These are destructive
> operations, ones which the kernel build system should not be making.
>
> Remove this behaviour.
>
> If this behaviour is required at installation time, this should be
> done by the installation external to the kernel makefiles, just like
> it would be done for 'make modules_install'.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> scripts/Makefile.dtbinst | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-28 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20150328132320.GA24391@n2100.arm.linux.org.uk>
2015-03-28 13:37 ` [PATCH] dtbsinstall: don't move target directory out of the way Russell King
2015-03-28 15:59 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).