From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:54626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305AbdAWPHb (ORCPT ); Mon, 23 Jan 2017 10:07:31 -0500 From: "Luis R. Rodriguez" Subject: [PATCH v2] firmware/Makefile: force recompilation if makefile changes Date: Mon, 23 Jan 2017 07:07:27 -0800 Message-Id: <20170123150727.4883-1-mcgrof@kernel.org> In-Reply-To: <20170118173156.16060-1-mcgrof@kernel.org> References: <20170118173156.16060-1-mcgrof@kernel.org> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: mmarek@suse.com Cc: linux-kbuild@vger.kernel.org, ming.lei@canonical.com, gregkh@linuxfoundation.org, teg@jklm.no, linux-kernel@vger.kernel.org, dwmw2@infradead.org, "Luis R. Rodriguez" If you modify the target asm we currently do not force the recompilation of the firmware files. The target asm is in the firmware/Makefile, peg this file as a dependency to require re-compilation of firmware targets when the asm changes. Signed-off-by: Luis R. Rodriguez --- Michal, I had this patch as part of my linker table series [0] but have split it off as its a small atomic separate change and can go in separately. Greg prefers this be reviewed by the kbuild tree so sending it your way. This v2 has no modifications, just resending it to the kbuild tree. [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org firmware/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/firmware/Makefile b/firmware/Makefile index e297e1b52636..fa3e81c2a97b 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ include/config/ppc32.h include/config/ppc64.h \ include/config/superh32.h include/config/superh64.h \ - include/config/x86_32.h include/config/x86_64.h) + include/config/x86_32.h include/config/x86_64.h \ + firmware/Makefile) $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) -- 2.11.0