From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21668C433E1 for ; Mon, 17 Aug 2020 22:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE1942072E for ; Mon, 17 Aug 2020 22:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730041AbgHQWJU (ORCPT ); Mon, 17 Aug 2020 18:09:20 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:50968 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728426AbgHQWJN (ORCPT ); Mon, 17 Aug 2020 18:09:13 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 1AF0D1C0BB6; Tue, 18 Aug 2020 00:09:09 +0200 (CEST) Date: Tue, 18 Aug 2020 00:09:08 +0200 From: Pavel Machek To: Linus Torvalds Cc: "Eric W. Biederman" , Al Viro , Michael Witten , Masahiro Yamada , Michal Marek , Cong Wang , Johannes Weiner , Sam Ravnborg , Linux Kernel Mailing List , Linux Kbuild mailing list , John Levon , John Levon , Andrew Morton Subject: Re: [PATCH] Makefile: Yes. Finally remove '-Wdeclaration-after-statement' Message-ID: <20200817220908.GA3701@amd> References: <20200816175303.GB1236603@ZenIV.linux.org.uk> <20200817204223.GB12414@amd> <87lfid6kpi.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2020-08-17 14:29:37, Linus Torvalds wrote: > On Mon, Aug 17, 2020 at 2:15 PM Eric W. Biederman = wrote: > > > > Does anyone remember why we added this warning? I had always thought > > it's purpose was to ensure we stayed within our chosen dialect of C. >=20 > As far as I'm concerned, that's the primary motivation. >=20 > I'm not seeing why we'd suddenly allow the "put variable declarations > anywhere" when we've been able to keep from doing it until now. >=20 > We're still building primarily good old K&R ANSI C, just with > extensions. Wild variable placement doesn't seem like a useful > extension. I certainly hope we are not going back to good old K&R C :-). Submitter believes "wild variable placement" can help with #ifdefs.. and that may be actually good tradeoff. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl87AAQACgkQMOfwapXb+vKiVgCeIkXAgbXAQQ5tusMee++/3DR4 lz8AnRYXzPxLP4LdF9kvOHHKNW1y76Vk =KDJT -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--