From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David Laight <David.Laight@aculab.com>,
'Nicolas Boichat' <drinkcat@chromium.org>,
"dianders@chromium.org" <dianders@chromium.org>,
"groeck@chromium.org" <groeck@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>,
Kars Mulder <kerneldev@karsmulder.nl>,
Kees Cook <keescook@chromium.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Will Deacon <will@kernel.org>, Yue Hu <huyue2@yulong.com>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] kernel/trace: Add DISALLOW_TRACE_PRINTK make option
Date: Mon, 24 Aug 2020 14:26:34 -0400 [thread overview]
Message-ID: <20200824142634.235acc7d@oasis.local.home> (raw)
In-Reply-To: <20200824134201.GM1891694@smile.fi.intel.com>
On Mon, 24 Aug 2020 16:42:01 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> How making it make's option prevent some "smart" distros to achieve the same?
> AFAIU any compile-time knob will allow to build a kernel w/o a feature and you
> are against of such kernel builds in distros. Catch-22?
Because it will fail the build if it finds a trace_printk() in the
compiled code, but doesn't touch the config that is shipped, nor does
it affect modules being built against this kernel.
This patch series is for those that do not want a trace_printk()
accidentally left behind in their own work and trigger that big warning
and scare their users. But it still gives an option for developers to
add a trace_printk.
That is, the decision to have trace_printk in a particular output
(vmlinux) is done at the compile time, and all it does is to make sure
one isn't present at that moment. This series is not about keeping them
out completely (test modules, etc), which a config option will.
-- Steve
next prev parent reply other threads:[~2020-08-24 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 2:59 [PATCH v5] kernel/trace: Add DISALLOW_TRACE_PRINTK make option Nicolas Boichat
2020-08-24 8:26 ` David Laight
2020-08-24 13:28 ` Steven Rostedt
2020-08-24 13:42 ` Andy Shevchenko
2020-08-24 18:26 ` Steven Rostedt [this message]
2020-08-24 13:30 ` Steven Rostedt
2020-08-25 0:38 ` Nicolas Boichat
2020-08-26 1:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824142634.235acc7d@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=gpiccoli@canonical.com \
--cc=groeck@chromium.org \
--cc=huyue2@yulong.com \
--cc=keescook@chromium.org \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).