From: Masahiro Yamada <masahiroy@kernel.org>
To: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Dmitry Safonov <0x7f454c46@gmail.com>,
afzal mohammed <afzal.mohd.ma@gmail.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] ia64: clean-up header dependency and build process, fix build warning
Date: Sat, 29 Aug 2020 14:15:21 +0900 [thread overview]
Message-ID: <20200829051524.706585-1-masahiroy@kernel.org> (raw)
Randy Dunlap reports the following warning with CONFIG_IA64_PALINFO=m:
../scripts/Makefile.build:68: 'arch/ia64/kernel/palinfo.ko' will not be built even though obj-m is specified.
../scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead.
This comes from the fact Kbuild descends into arch/ia64/kernel/ twice.
First, to generate <generated/nr-irqs.h>,
Second, to build kernel and module objects.
The warning is emitted in the first descend because it is not the
intended usage.
I looked into the code closely, and noticed arch/ia64/kernel/nr-irqs.c
was not needed in the first place.
It was separated out of arch/ia64/kernel/asm-offsets.c just because
<asm/mca.h> was including too many bogus headers.
IA64 is not actively maintained, and there exists unneeded obsolete code.
The first two patches are the outcome when I played with ARCH=ia64 builds,
but not prerequisites for 3/3. Anyway I believe they are nice cleanups
and folded in this patch set.
3/3 is the important one to fix the false positive warning,
and it is a nice cleanup too.
Masahiro Yamada (3):
ia64: do not typedef struct pal_min_state_area_s
ia64: remove unneeded header includes from <asm/mca.h>
ia64: remove generated/nr-irqs.h generation to fix build warning
arch/ia64/Makefile | 6 ------
arch/ia64/include/asm/irq.h | 4 +++-
arch/ia64/include/asm/mca.h | 11 ++++-------
arch/ia64/include/asm/pal.h | 4 ++--
arch/ia64/include/asm/sal.h | 2 +-
arch/ia64/kernel/Makefile | 5 -----
arch/ia64/kernel/asm-offsets.c | 18 +++++++++---------
arch/ia64/kernel/efi.c | 1 +
arch/ia64/kernel/mca.c | 5 +++--
arch/ia64/kernel/mca_drv.c | 2 +-
arch/ia64/kernel/nr-irqs.c | 22 ----------------------
11 files changed, 24 insertions(+), 56 deletions(-)
delete mode 100644 arch/ia64/kernel/nr-irqs.c
--
2.25.1
next reply other threads:[~2020-08-29 5:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 5:15 Masahiro Yamada [this message]
2020-08-29 5:15 ` [PATCH 1/3] ia64: do not typedef struct pal_min_state_area_s Masahiro Yamada
2020-08-29 18:21 ` Randy Dunlap
2020-08-29 5:15 ` [PATCH 2/3] ia64: remove unneeded header includes from <asm/mca.h> Masahiro Yamada
2020-08-29 18:20 ` Randy Dunlap
2020-08-31 15:00 ` Ard Biesheuvel
2020-08-29 5:15 ` [PATCH 3/3] ia64: remove generated/nr-irqs.h generation to fix build warning Masahiro Yamada
2020-08-29 18:22 ` Randy Dunlap
2021-02-07 2:46 ` Masahiro Yamada
2020-12-04 5:43 ` [PATCH 0/3] ia64: clean-up header dependency and build process, " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829051524.706585-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=fenghua.yu@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).