From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B11C43461 for ; Thu, 3 Sep 2020 22:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 045D720786 for ; Thu, 3 Sep 2020 22:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Oywi+Oec" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729348AbgICWsk (ORCPT ); Thu, 3 Sep 2020 18:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728309AbgICWsj (ORCPT ); Thu, 3 Sep 2020 18:48:39 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 032FBC061244 for ; Thu, 3 Sep 2020 15:48:39 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id w186so3272352pgb.8 for ; Thu, 03 Sep 2020 15:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=N0kZAZSHXumzFlr+P3KSPa/xm/RvLBA66H9sz+ks+Hk=; b=Oywi+Oecms9EF3LovMy4YD4zvKOmcmZdnBLP+RpPo6vJNZvq4Wn2exUrN/cYyBRvkj QpHAOCzGUNXF3wIsqPQqbSCg3YTtavUaX+FrsM9NvoAyqfJuCJ9m05znPNWTjs0F38rh A9mlrLTr/MJ+vIHnNL9G8CGzKKp8or3nRT3jg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N0kZAZSHXumzFlr+P3KSPa/xm/RvLBA66H9sz+ks+Hk=; b=TpLtu2KARbOeBmjwmuQXWaFQEZ6J2n4bVtUz3cYDqXAHxA1WzTROS82jbhXVGGtWED xrY9DoSX8/W5XWUgT9e+Gm9QLJKpOnQoh3MmRJAI+xlOB4id46W0xskntR6IWHy3Hx/R LIaMK/zb3IA7ntLOTNq2A+BTNKi1oYTQqRZeZ8r77FHiaykNvbfPm7AZjp7ZPhwKIdBL DzgElEuPqSIE5LL8vKSgPk0gECVv2lRlKEeO9JtwugYRstaejJNyri2JQN194SOLkSRF 33lBQlg0XwuxA9B4AEyGF0IT8DRb8dZffaECEYnc0TqZJPqLhcLJCzj19vPcoNVK4Cx4 x1mQ== X-Gm-Message-State: AOAM532AAPDEgDvB36odgN/M+9Pe9d86xZfnl/aUugA2ZN+bZv8ubrf4 PZ3uhZLVkBQpJSZn0xblkNr9ug== X-Google-Smtp-Source: ABdhPJzhSDd0wUjK+CLAjJOCS+RRpwDZiMWAA9QXCsfZew5vqJTkaYMpTKaYMs063H+/576UYhDU1A== X-Received: by 2002:a63:f546:: with SMTP id e6mr4666553pgk.7.1599173318626; Thu, 03 Sep 2020 15:48:38 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q71sm3612032pja.9.2020.09.03.15.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:48:37 -0700 (PDT) Date: Thu, 3 Sep 2020 15:48:36 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 28/28] x86, build: allow LTO_CLANG and THINLTO to be selected Message-ID: <202009031548.84902F3F@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-29-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-29-samitolvanen@google.com> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:53PM -0700, Sami Tolvanen wrote: > Allow CONFIG_LTO_CLANG and CONFIG_THINLTO to be enabled. > > Signed-off-by: Sami Tolvanen I think it might be worth detailing why these arguments aren't handled in the normal fashion under Clang's LTO. Regardless, it's needed to make it work, so: Reviewed-by: Kees Cook -- Kees Cook