* [PATCH v1] kbuild: enforce -Werror=return-type
@ 2020-10-05 10:10 Olaf Hering
2020-10-11 13:27 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2020-10-05 10:10 UTC (permalink / raw)
To: linux-kbuild, linux-kernel; +Cc: Olaf Hering, Masahiro Yamada, Michal Marek
Catch errors which at least gcc tolerates by default:
warning: 'return' with no value, in function returning non-void [-Wreturn-type]
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index f84d7e4ca0be..7b2e63e7be18 100644
--- a/Makefile
+++ b/Makefile
@@ -942,6 +942,9 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=date-time)
# enforce correct pointer usage
KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
+# enforce correct return type
+KBUILD_CFLAGS += $(call cc-option,-Werror=return-type)
+
# Require designated initializers for all marked structures
KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] kbuild: enforce -Werror=return-type
2020-10-05 10:10 [PATCH v1] kbuild: enforce -Werror=return-type Olaf Hering
@ 2020-10-11 13:27 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2020-10-11 13:27 UTC (permalink / raw)
To: Olaf Hering
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List, Michal Marek
On Mon, Oct 5, 2020 at 7:13 PM Olaf Hering <olaf@aepfle.de> wrote:
>
> Catch errors which at least gcc tolerates by default:
> warning: 'return' with no value, in function returning non-void [-Wreturn-type]
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index f84d7e4ca0be..7b2e63e7be18 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -942,6 +942,9 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=date-time)
> # enforce correct pointer usage
> KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
>
> +# enforce correct return type
> +KBUILD_CFLAGS += $(call cc-option,-Werror=return-type)
> +
cc-option is unneeded because the minimal supported versions
of GCC/Clang support -Werror=return-type.
You can hard-code and add it around line 500.
> # Require designated initializers for all marked structures
> KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init)
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-11 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 10:10 [PATCH v1] kbuild: enforce -Werror=return-type Olaf Hering
2020-10-11 13:27 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).