* [PATCH] Kbuild.include: remove leftover comment for filechk utility
@ 2020-10-16 12:58 Rasmus Villemoes
2020-10-17 0:52 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2020-10-16 12:58 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek
Cc: Rasmus Villemoes, Masahiro Yamada, linux-kbuild, linux-kernel
After commit 43fee2b23895 ("kbuild: do not redirect the first
prerequisite for filechk"), the rule is no longer automatically passed
$< as stdin, so remove the stale comment.
Fixes: 43fee2b23895 ("kbuild: do not redirect the first prerequisite for filechk")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
scripts/Kbuild.include | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index 83a1637417e5..08e011175b4c 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -56,8 +56,6 @@ kecho := $($(quiet)kecho)
# - If no file exist it is created
# - If the content differ the new file is used
# - If they are equal no change, and no timestamp update
-# - stdin is piped in from the first prerequisite ($<) so one has
-# to specify a valid file as first prerequisite (often the kbuild file)
define filechk
$(Q)set -e; \
mkdir -p $(dir $@); \
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Kbuild.include: remove leftover comment for filechk utility
2020-10-16 12:58 [PATCH] Kbuild.include: remove leftover comment for filechk utility Rasmus Villemoes
@ 2020-10-17 0:52 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2020-10-17 0:52 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Michal Marek, Linux Kbuild mailing list, Linux Kernel Mailing List
On Fri, Oct 16, 2020 at 9:59 PM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> After commit 43fee2b23895 ("kbuild: do not redirect the first
> prerequisite for filechk"), the rule is no longer automatically passed
> $< as stdin, so remove the stale comment.
>
> Fixes: 43fee2b23895 ("kbuild: do not redirect the first prerequisite for filechk")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
Applied to linux-kbuild. Thanks.
> scripts/Kbuild.include | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index 83a1637417e5..08e011175b4c 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -56,8 +56,6 @@ kecho := $($(quiet)kecho)
> # - If no file exist it is created
> # - If the content differ the new file is used
> # - If they are equal no change, and no timestamp update
> -# - stdin is piped in from the first prerequisite ($<) so one has
> -# to specify a valid file as first prerequisite (often the kbuild file)
> define filechk
> $(Q)set -e; \
> mkdir -p $(dir $@); \
> --
> 2.23.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-17 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 12:58 [PATCH] Kbuild.include: remove leftover comment for filechk utility Rasmus Villemoes
2020-10-17 0:52 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).