From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BA7C4338F for ; Thu, 19 Aug 2021 06:48:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7774C60FDA for ; Thu, 19 Aug 2021 06:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231404AbhHSGsj (ORCPT ); Thu, 19 Aug 2021 02:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231347AbhHSGsi (ORCPT ); Thu, 19 Aug 2021 02:48:38 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49EECC061756 for ; Wed, 18 Aug 2021 23:48:03 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id n5so4272613pjt.4 for ; Wed, 18 Aug 2021 23:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LZbrqbnGVF4s6R8ZE29TSFBtRgWG1aFf5wVvmTN0Kls=; b=LzpwSI+PQ849sv+/d2wxrfSs4Stz85cvghRvs9r62qeewVfZppUpmwfon/gbQBU0LX cCuBbMRsYTuBSGa8L2dOIOhwrfCAdgb7dKrQJu9iJ5l86UXsTJCt0bwwYwUPUmRZqLuo /lpq+/Nz+2q92pnRVoUf2ddPftWpPY5/mlDMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LZbrqbnGVF4s6R8ZE29TSFBtRgWG1aFf5wVvmTN0Kls=; b=oHuGRhNYk1kBo6pRfWan61keo0lfOR2RXyizt4tQyvv3Y33rK073t3fk1BAwBeT4LV eWhNc/kdG3MNubt70Y6eOavV909fw7is+N1v8wTbRsOYGD1hOFHMBvaSEZbUpXPRkkxv 7XBgFX61uXwpYY462uP7XOgeqGVQpb9aBVhvmjBD712+Qr2Glt08p0zRuzRDOW7l8g3R SP7xOU2/qhzHIEB7lR/yBRy120By5fmc6ODdJVmegw4j43jkADi5idoptdkIXqx2UShL fCrnVUcolSXOwJ9c960DsxwVnAV9KC30aiwsaXMt4P3Q9Wz0mCEXCqEMMJLl8CIX8MUZ Y0cQ== X-Gm-Message-State: AOAM530m+gNl3+Y1ed+IzHuYqbcQwH+xUn78lTQxZh8aTElRWG+jiuwQ 47YGJSOuRuLr2qMlHR54AeGM3A== X-Google-Smtp-Source: ABdhPJw8G2jVp3T8UDYSrVTUZDASHoPOochThbPOlZLvNxJjGz+1teyquH91ZQLct5RsTmLvrQxSfw== X-Received: by 2002:a17:902:6b03:b0:12d:8f77:83d1 with SMTP id o3-20020a1709026b0300b0012d8f7783d1mr10332933plk.11.1629355682754; Wed, 18 Aug 2021 23:48:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c26sm2442811pgl.10.2021.08.18.23.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 23:48:02 -0700 (PDT) Date: Wed, 18 Aug 2021 23:48:01 -0700 From: Kees Cook To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Sami Tolvanen , linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , clang-built-linux@googlegroups.com Subject: Re: [PATCH 02/13] gen_compile_commands: extract compiler command from a series of commands Message-ID: <202108182347.0CDD87706@keescook> References: <20210819005744.644908-1-masahiroy@kernel.org> <20210819005744.644908-3-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819005744.644908-3-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Thu, Aug 19, 2021 at 09:57:33AM +0900, Masahiro Yamada wrote: > The current gen_compile_commands.py assumes that objects are always > built by a single command. > > It makes sense to support cases where objects are built by a series of > commands: > > cmd_ := ; > > One use-case is is a compiler command, and is > an objtool command. > > It allows *.cmd files to contain an objtool command so that any change > in it triggers object rebuilds. > > If ; appears after the C source file, take the first command. > > Signed-off-by: Masahiro Yamada Seems reasonable, given patch 3. Reviewed-by: Kees Cook -Kees > --- > > scripts/clang-tools/gen_compile_commands.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py > index b7e9ecf16e56..0033eedce003 100755 > --- a/scripts/clang-tools/gen_compile_commands.py > +++ b/scripts/clang-tools/gen_compile_commands.py > @@ -18,7 +18,7 @@ _DEFAULT_OUTPUT = 'compile_commands.json' > _DEFAULT_LOG_LEVEL = 'WARNING' > > _FILENAME_PATTERN = r'^\..*\.cmd$' > -_LINE_PATTERN = r'^cmd_[^ ]*\.o := (.* )([^ ]*\.c)$' > +_LINE_PATTERN = r'^cmd_[^ ]*\.o := (.* )([^ ]*\.c) *(;|$)' > _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'] > # The tools/ directory adopts a different build system, and produces .cmd > # files in a different format. Do not support it. > -- > 2.30.2 > -- Kees Cook