linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>,
	Guenter Roeck <linux@roeck-us.net>, Lee Jones <lee@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kbuild@vger.kernel.org,
	Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 9/9] [RFC] extrawarn: enable more W=1 warnings by default
Date: Mon, 14 Aug 2023 12:52:40 -0700	[thread overview]
Message-ID: <20230814195240.GA1060032@dev-arch.thelio-3990X> (raw)
In-Reply-To: <defc2883-659b-4805-a279-783fbd3357cc@app.fastmail.com>

On Fri, Aug 11, 2023 at 08:23:45PM +0200, Arnd Bergmann wrote:
> On Fri, Aug 11, 2023, at 18:09, Nathan Chancellor wrote:
> > On Fri, Aug 11, 2023 at 04:03:27PM +0200, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >> 
> >> A number of warning options from the W=1 set are completely clean in current
> >> kernels, so we should just enable them by default, including a lot of warnings
> >> that are part of -Wextra, so just turn on -Wextra by default.
> >> 
> >> The -Woverride-init, -Wvoid-pointer-to-enum-cast and
> >> -Wmissing-format-attribute warnings are part of -Wextra but still produce
> >> some legitimate warnings that need to be fixed, so leave them at the
> >> W=1 level but turn them off otherwise.
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ...
> >> -KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
> >> -KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
> >> -KBUILD_CFLAGS += $(call cc-disable-warning, cast-function-type-strict)
> >
> > I am still running through my builds but I don't think that dropping
> > these three is acceptable at the moment. I see a good number of all of
> > these warnings in -next still. I see some patches that I have picked up
> > to address a couple of the really noisy ones but some others that I
> > looked at are not fixed. I'll have a list eventually.
> 
> Ok, thanks. I have a backlog of warning fixes in my randconfig
> tree, which is currently clean with these warnings addressed, at
> least on arm/arm64/x86 and it looks like there are a couple that
> I've never sent out so far. I'll drop the above for now, as I
> won't have time to send all the fixes before my vacation.

Thanks, that takes care of the vast majority of extra warnings that this
series produces. I have included all my build logs at [1].

The slightly-filtered-warnings file is the result of searching for all
warnings in the log files and passing them through 'sort | uniq -c',
additionally ignoring the instances of -Wnull-pointer-arithmetic that
are present in certain configurations, as those are pretty well known at
this point.

The more-filtered-warnings file does the same thing but also ignores
instances of the three warnings above, which just reveals some instances
of -Wunused-but-set-parameter, which I am pretty sure I have seen you
sent fixes for recently, so I think with those three warnings left as
disabled, this series should be safe.

[1]: https://github.com/nathanchance/bug-files/tree/9100c6a21cbdce3c03fbca1bd00a7c34f316a137/enable-more-W%3D1-warnings-by-default

Cheers,
Nathan

      reply	other threads:[~2023-08-14 19:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 14:03 [PATCH 0/9] Kbuild: warning options cleanup and more warnings Arnd Bergmann
2023-08-11 14:03 ` [PATCH 1/9] Kbuild: only pass -fno-inline-functions-called-once for gcc Arnd Bergmann
2023-08-11 14:14   ` Nathan Chancellor
2023-08-11 14:23     ` Arnd Bergmann
2023-08-11 14:03 ` [PATCH 2/9] Kbuild: consolidate warning flags in scripts/Makefile.extrawarn Arnd Bergmann
2023-08-11 14:19   ` Nathan Chancellor
2023-08-11 14:26     ` Arnd Bergmann
2023-08-12  7:21       ` Masahiro Yamada
2023-08-20  1:36       ` Masahiro Yamada
2023-08-11 14:03 ` [PATCH 3/9] Kbuild: avoid duplicate warning options Arnd Bergmann
2023-08-12  9:21   ` Masahiro Yamada
2023-08-12  9:28     ` Arnd Bergmann
2023-08-20  1:38       ` Masahiro Yamada
2023-08-11 14:03 ` [PATCH 4/9] extrawarn: don't turn off -Wshift-negative-value for gcc-9 Arnd Bergmann
2023-08-12 12:04   ` Masahiro Yamada
2023-08-11 14:03 ` [PATCH 5/9] extrawarn: enable format and stringop overflow warnings in W=1 Arnd Bergmann
2023-08-12 13:10   ` Masahiro Yamada
2023-08-20  1:40     ` Masahiro Yamada
2023-08-21 18:26     ` Nick Desaulniers
2023-08-11 14:03 ` [PATCH 6/9] extrawarn: move -Wrestrict into W=1 warnings Arnd Bergmann
2023-08-12 13:20   ` Masahiro Yamada
2023-08-20  1:45   ` Masahiro Yamada
2023-08-11 14:03 ` [PATCH 7/9] extrawarn: do not disable -Wmain at W=1 level Arnd Bergmann
2023-08-11 14:03 ` [PATCH 8/9] extrawarn: enable more warnings in W=2 Arnd Bergmann
2023-08-11 14:03 ` [PATCH 9/9] [RFC] extrawarn: enable more W=1 warnings by default Arnd Bergmann
2023-08-11 16:09   ` Nathan Chancellor
2023-08-11 18:23     ` Arnd Bergmann
2023-08-14 19:52       ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814195240.GA1060032@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=masahiroy@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).