archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <>
	Masahiro Yamada <>,
	Nathan Chancellor <>,
	Nick Desaulniers <>,
	Nicolas Schier <>
Subject: [PATCH] kbuild: get lib-y objects back to static library
Date: Wed, 23 Aug 2023 21:08:16 +0900	[thread overview]
Message-ID: <> (raw)

Revert the following two commits:

 - 7273ad2b08f8 ("kbuild: link lib-y objects to vmlinux forcibly when CONFIG_MODULES=y")
 - 7f2084fa55e6 ("[kbuild] handle exports in lib-y objects reliably")

Now, lib-y is back to static library again, and the link order is
consistent w/wo CONFIG_MODULES.

Since commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
modpost"), .vmlinux.export.c contains references to exported symbols.
If a symbol in a lib-y object is exported, that object is always linked
even without any explicit user in vmlinux.

Signed-off-by: Masahiro Yamada <>

 Makefile | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Makefile b/Makefile
index 87a9eef3fb4b..71e9c65d9eae 100644
--- a/Makefile
+++ b/Makefile
@@ -1113,12 +1113,7 @@ export ARCH_DRIVERS	:= $(drivers-y) $(drivers-m)
 # Externally visible symbols (used by
 KBUILD_VMLINUX_OBJS := ./built-in.a
-KBUILD_VMLINUX_OBJS += $(patsubst %/, %/lib.a, $(filter %/, $(libs-y)))
-KBUILD_VMLINUX_LIBS := $(filter-out %/, $(libs-y))
 KBUILD_VMLINUX_LIBS := $(patsubst %/,%/lib.a, $(libs-y))
 export KBUILD_LDS          := arch/$(SRCARCH)/kernel/

             reply	other threads:[~2023-08-23 12:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 12:08 Masahiro Yamada [this message]
2023-08-23 20:20 ` [PATCH] kbuild: get lib-y objects back to static library Nathan Chancellor
2023-08-24 18:59   ` Nathan Chancellor
2023-08-25 16:58     ` Nick Desaulniers
2023-08-26  0:06       ` Masahiro Yamada
2023-08-26  0:55         ` Nick Desaulniers
2023-08-24  1:44 ` Masahiro Yamada
2023-08-26  2:37 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).