From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FEAC82D9D for ; Mon, 15 Apr 2024 16:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713197764; cv=none; b=NhNo2EWDeHwJiivpcqsTdNujQ8qCOKEHhgx66ogY9FklQqazb4GBaW3px63syYNJkKRw5Nv51HnYPcbde2j0i1zt3hHS3iG0mfXCGcWqM5+Yhw3yUx2WIlHm1PlI0OnKwF6nEa6HfIlTZ+6+x5fBi1hVMcBgtmkT0Z/VNSmYeLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713197764; c=relaxed/simple; bh=FpomtvzrUGqRcfkT9HroMgk+hHbU5BpIvAwjwjQwBrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rqrmAP6InBoNOphNDw+irGvbLFs2RlOKCDVPiQVf6WFHpBLTjFvuz++z4xlAVZrH9FHvRNOnYgJOQdeA5mIwANhQPhR+VZndkKtQ374fe5kgCTnKLQDHE8z/aBdrnK0/WhDYP5cNcYaCBZYNL+3c2iBTMHXZnxtdyPZQ3IH2vqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nvAduJRY; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nvAduJRY" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6eaf9565e6bso2060082b3a.2 for ; Mon, 15 Apr 2024 09:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713197751; x=1713802551; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qxv6+5Ux2yTI1FE4TVPvIu4J5fO2aZv6AEiUOC/zMkg=; b=nvAduJRYogn99/bDXBlB0HTNpenyZk0GyOuWAjaykx67sfB8YFUujFYjSKtvrOhh+B qG/5zcAMRmEax0JWGUWh8TOMw1gM6iBjed1dZte8Befwjc1jhDlWc3Bcw/xafPrPmfQP 0SHnZia6wbMRyBFjIZpjk221eBa6uUxhEPMdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713197751; x=1713802551; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qxv6+5Ux2yTI1FE4TVPvIu4J5fO2aZv6AEiUOC/zMkg=; b=aiK/oYibzvW9jjF31oLJDnH76Q6RmaT8wKPL+Idu3oYnrnKlEJLNGhIxAFSDIk32cN 1sxpQQzjTecjxT/smazvCS4E9TlOa8L5etx7ySJFzsM01uXRlr/B7rPQGVsrxfjqhzqD z50sXT0osjm5X7dWUPxB0WG+CSfbcgYnntyTTvV4xr9ja3J2ZeZ4Ip5XdCImGpcksMm5 aVg4wF6zVfRZe01WeR+P3cY8rL5uSvutP0tMBasY58SnPtx7c9LqoTijtfUyykWmB1Vx KKZAADo9/DCCRx0AI4EMmuoU4BchQZ9imhP1xJo+fk/CL0HVwDGXRF9AIlZJGSXcBlMw Gcuw== X-Forwarded-Encrypted: i=1; AJvYcCVlla1Lzl66w8rpUduVkUfSld+td/TAGe1R3r797wKNlEN7AgFotWu95krZENX6KME2iJDIzRrpR7FJva1ya9PEXQyIV4hmSFYQ0uJZ X-Gm-Message-State: AOJu0YwLUeQawFJLEaTaVav5zUI727q/e+Jw+wfssIuqb2PG8pPWjb2H ZjbiN9Y0XGvSFeu5D4zAt+GrRiOs5pmPtumxsPttPokZrOXMSzQliREqaAzG/g== X-Google-Smtp-Source: AGHT+IG4IR67yyuHStapORNuulY4crr6d/N1FjMFOe9RUErHsYbs5cWd6dPjndtXS3Umi/usTWq4oQ== X-Received: by 2002:a05:6a00:4b51:b0:6e6:89ad:1233 with SMTP id kr17-20020a056a004b5100b006e689ad1233mr10566964pfb.2.1713197751331; Mon, 15 Apr 2024 09:15:51 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id gs23-20020a056a004d9700b006ed4f616ec4sm7394323pfb.57.2024.04.15.09.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 09:15:51 -0700 (PDT) Date: Mon, 15 Apr 2024 09:15:50 -0700 From: Kees Cook To: Arnd Bergmann Cc: Andrew Morton , Arnd Bergmann , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] [v3] kbuild: enable -Wcast-function-type-strict unconditionally Message-ID: <202404150915.75918C8B3A@keescook> References: <20240415122037.1983124-1-arnd@kernel.org> <20240415122037.1983124-6-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415122037.1983124-6-arnd@kernel.org> On Mon, Apr 15, 2024 at 02:20:36PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > All known function cast warnings are now addressed, so the warning can > be enabled globally to catch new ones more quickly. Also yay! :) Reviewed-by: Kees Cook > > Signed-off-by: Arnd Bergmann > --- > scripts/Makefile.extrawarn | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn > index 202e26e6f29f..1d13cecc7cc7 100644 > --- a/scripts/Makefile.extrawarn > +++ b/scripts/Makefile.extrawarn > @@ -129,7 +129,6 @@ endif > KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast) > KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare > KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access) > -KBUILD_CFLAGS += $(call cc-disable-warning, cast-function-type-strict) > KBUILD_CFLAGS += -Wno-enum-compare-conditional > KBUILD_CFLAGS += -Wno-enum-enum-conversion > endif > -- > 2.39.2 > -- Kees Cook