From: Jeroen Hofstee <dasuboot@myspectrum.nl>
To: Hans de Goede <hdegoede@redhat.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
u-boot@lists.denx.de
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [U-Boot] [PATCH] kconfig: Fix compiler warning in menu.c
Date: Fri, 01 Aug 2014 00:21:35 +0200 [thread overview]
Message-ID: <53DAC16F.7030301@myspectrum.nl> (raw)
In-Reply-To: <1406816503-31963-1-git-send-email-hdegoede@redhat.com>
Hello Hans,
On 31-07-14 16:21, Hans de Goede wrote:
> This fixes the following compiler warning:
>
> In file included from scripts/kconfig/zconf.tab.c:2537:0:
> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
> scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> jump->offset = strlen(r->s);
> ^
> In file included from scripts/kconfig/zconf.tab.c:2537:0:
> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
> struct jump_key *jump;
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> scripts/kconfig/menu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index a26cc5d..584e0fc 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
> {
> int i, j;
> struct menu *submenu[8], *menu, *location = NULL;
> - struct jump_key *jump;
> + struct jump_key *jump = NULL;
>
> str_printf(r, _("Prompt: %s\n"), _(prop->text));
> menu = prop->menu->parent;
And if you combine head && location into a single boolean,
does this warning still occur? Not that it matters that much
in this case, since it is a host tool, but I guess the compiler
does intend to assign NULL while there is no reason to do so.
Regards,
Jeroen
prev parent reply other threads:[~2014-07-31 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 14:21 [PATCH] kconfig: Fix compiler warning in menu.c Hans de Goede
2014-07-31 20:10 ` [U-Boot] " Jeroen Hofstee
2014-07-31 21:32 ` Hans de Goede
2014-07-31 22:21 ` Jeroen Hofstee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DAC16F.7030301@myspectrum.nl \
--to=dasuboot@myspectrum.nl \
--cc=hdegoede@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u-boot@lists.denx.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).