linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Silvio Fricke <silvio.fricke@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, Justin Lecher <jlec@gentoo.org>
Subject: Re: [RFC] [PATCH] kconfig: menuconfig: pkg-config should base upon default configuration
Date: Fri, 22 Aug 2014 13:07:16 +0200	[thread overview]
Message-ID: <53F72464.6060401@suse.cz> (raw)
In-Reply-To: <1a72fd7040a988e84a81c0e5aaef50c33064f576.1407766447.git.silvio.fricke@gmail.com>

Dne 11.8.2014 16:22, Silvio Fricke napsal(a):
> Since fc9c6e0 "menuconfig: optionally use pkg-config to detect ncurses
> libs" we use pkg-config, but some cross toolchains (like yocto tc)
> change the search pathes for pc files with some PKG_CONFIG_* environment
> variables.
> 
> With this patch we ensure that we only get the host config options for
> ncurses and don't mix with others not relevant settings.
> 
> Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index 9d2a4c5..a067d3c 100644
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -1,6 +1,9 @@
>  #!/bin/sh
>  # Check ncurses compatibility
>  
> +unset PKG_CONFIG_PATH
> +unset PKG_CONFIG_SYSROOT_DIR

PKG_CONFIG_SYSROOT_DIR is clearly meant for cross-compiling and we are
never cross-compiling kconfig. However, PKG_CONFIG_PATH has valid use
cases even when not cross-compiling. Which variables exactly does yocto set?

It might also be a good idea for yocto to special case the kernel and do
not set the variables, because we are not cross-compiling any userspace
programs.

Michal

  reply	other threads:[~2014-08-22 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 14:22 [RFC] [PATCH] pkg-config default search pathes Silvio Fricke
2014-08-11 14:22 ` [RFC] [PATCH] kconfig: menuconfig: pkg-config should base upon default configuration Silvio Fricke
2014-08-22 11:07   ` Michal Marek [this message]
2014-08-11 17:23 ` [RFC] [PATCH] pkg-config default search pathes justin
2014-08-11 17:41   ` Silvio Fricke
2014-08-11 18:04     ` justin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F72464.6060401@suse.cz \
    --to=mmarek@suse.cz \
    --cc=jlec@gentoo.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=silvio.fricke@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).