From: Michal Marek <mmarek@suse.cz>
To: linux-kbuild@vger.kernel.org
Cc: sam@ravnborg.org, yamada.m@jp.panasonic.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Do not reference *-n variables in the Makefile
Date: Thu, 02 Oct 2014 15:35:35 +0200 [thread overview]
Message-ID: <542D54A7.604@suse.cz> (raw)
In-Reply-To: <1412256796-4111-1-git-send-email-mmarek@suse.cz>
On 2014-10-02 15:33, Michal Marek wrote:
> Kconfig options are either 'y', 'm', or undefined.
>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index efbd2cb..106f300 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -868,9 +868,7 @@ vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
> $(net-y) $(net-m) $(libs-y) $(libs-m)))
>
> vmlinux-alldirs := $(sort $(vmlinux-dirs) $(patsubst %/,%,$(filter %/, \
> - $(init-n) $(init-) \
> - $(core-n) $(core-) $(drivers-n) $(drivers-) \
> - $(net-n) $(net-) $(libs-n) $(libs-))))
> + $(init-) $(core-) $(drivers-) $(net-) $(libs-))))
Actually, all the directories are hardcoded in
{init,code,drivers,net,libs}-y; there are currently no Kconfig variables
involved. But let's keep this generic and handle *-m and *- just in case.
Michal
next prev parent reply other threads:[~2014-10-02 13:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 10:26 [PATCH 0/3] kbuild: Clean up makefiles and then drop obj-n an obj-n Masahiro Yamada
2014-09-09 10:26 ` [PATCH 1/3] kbuild: remove unnecessary "obj- := dummy.o" trick Masahiro Yamada
2014-09-09 16:21 ` Peter Foley
2014-09-09 17:43 ` Mike Turquette
2014-09-09 23:45 ` Simon Horman
2014-09-10 3:40 ` David Miller
2014-09-09 10:26 ` [PATCH 2/3] kbuild: remove unnecessary variable initializaions Masahiro Yamada
2014-09-09 11:52 ` Nicolas Ferre
2014-09-09 16:23 ` Peter Foley
2014-09-23 14:56 ` Linus Walleij
2014-09-09 10:26 ` [PATCH 3/3] kbuild: remove obj-n and lib-n handling Masahiro Yamada
2014-09-09 16:20 ` Peter Foley
2014-10-02 13:02 ` Michal Marek
2014-10-02 13:04 ` Michal Marek
2014-10-02 13:17 ` Masahiro Yamada
2014-10-02 13:33 ` [PATCH] kbuild: Do not reference *-n variables in the Makefile Michal Marek
2014-10-02 13:35 ` Michal Marek [this message]
2014-10-02 13:55 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D54A7.604@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).