From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
david.vrabel@citrix.com, boris.ostrovsky@oracle.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
mmarek@suse.cz, linux-kbuild@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 4/4] xen: use generated hypercall symbols in arch/x86/xen/xen-head.S
Date: Mon, 15 Dec 2014 12:05:47 +0000 [thread overview]
Message-ID: <548ECE9B.3040105@citrix.com> (raw)
In-Reply-To: <1418321065-10212-5-git-send-email-jgross@suse.com>
On 11/12/14 18:04, Juergen Gross wrote:
> Instead of manually list each hypercall in arch/x86/xen/xen-head.S
> use the auto generated symbol list.
>
> This also corrects the wrong address of xen_hypercall_mca which was
> located 32 bytes higher than it should.
>
> Symbol addresses have been verified to match the correct ones via
> objdump output.
[...]
> +
> +#define HYPERCALL(n) \
> + .equ xen_hypercall_##n, hypercall_page + __HYPERVISOR_##n * 32; \
> + .type xen_hypercall_##n, function; .size xen_hypercall_##n, 32
> +#include <asm/xen-hypercalls.h>
> +#undef HYPERCALL
The gas manual[1] suggests the syntax you've used for .type is invalid
and suggest using .type <name>, STT_FUNC
> +
> .balign PAGE_SIZE
You can remove this .balign.
David
[1] https://sourceware.org/binutils/docs/as/Type.html#Type
next prev parent reply other threads:[~2014-12-15 12:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 18:04 [PATCH 0/4] xen: auto-generate symbols for xen hypercalls Juergen Gross
2014-12-11 18:04 ` [PATCH 1/4] xen: build infrastructure for generating hypercall depending symbols Juergen Gross
2014-12-12 22:48 ` Boris Ostrovsky
2014-12-15 5:20 ` Juergen Gross
2014-12-15 10:00 ` [Xen-devel] " Jan Beulich
2014-12-15 11:38 ` David Vrabel
2014-12-15 11:47 ` Jan Beulich
2014-12-16 14:51 ` David Vrabel
2014-12-16 14:40 ` Juergen Gross
2014-12-11 18:04 ` [PATCH 2/4] xen: synchronize include/xen/interface/xen.h with xen Juergen Gross
2014-12-15 11:45 ` [Xen-devel] " David Vrabel
2014-12-11 18:04 ` [PATCH 3/4] xen: use generated hypervisor symbols in arch/x86/xen/trace.c Juergen Gross
2014-12-15 11:46 ` [Xen-devel] " David Vrabel
2014-12-11 18:04 ` [PATCH 4/4] xen: use generated hypercall symbols in arch/x86/xen/xen-head.S Juergen Gross
2014-12-15 12:05 ` David Vrabel [this message]
2014-12-16 5:55 ` [Xen-devel] " Juergen Gross
2014-12-16 10:24 ` David Vrabel
2014-12-16 11:20 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548ECE9B.3040105@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).