From: Shuah Khan <shuahkh@osg.samsung.com>
To: Tim Bird <tim.bird@sonymobile.com>,
"mmarek@suse.cz" <mmarek@suse.cz>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"keescook@chromium.org" <keescook@chromium.org>,
"tranmanphong@gmail.com" <tranmanphong@gmail.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"cov@codeaurora.org" <cov@codeaurora.org>,
"dh.herrmann@gmail.com" <dh.herrmann@gmail.com>,
"hughd@google.com" <hughd@google.com>,
"bobby.prani@gmail.com" <bobby.prani@gmail.com>,
"serge.hallyn@ubuntu.com" <serge.hallyn@ubuntu.com>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"josh@joshtriplett.org" <josh@joshtriplett.org>,
"koct9i@gmail.com" <koct9i@gmail.com>
Cc: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: WIP alternative - was Re: [PATCH v3 14/20] selftests/size: add install target to enable test install
Date: Mon, 05 Jan 2015 14:28:53 -0700 [thread overview]
Message-ID: <54AB0215.5020409@osg.samsung.com> (raw)
In-Reply-To: <54A4B174.2010501@sonymobile.com>
On 12/31/2014 07:31 PM, Tim Bird wrote:
> On 12/24/2014 08:27 AM, Shuah Khan wrote:
>> Add a new make target to enable installing test. This target
>> installs test in the kselftest install location and add to the
>> kselftest script to run the test. Install target can be run
>> only from top level kernel source directory.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> tools/testing/selftests/size/Makefile | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile
>> index 04dc25e..bb7113b 100644
>> --- a/tools/testing/selftests/size/Makefile
>> +++ b/tools/testing/selftests/size/Makefile
>> @@ -1,12 +1,22 @@
>> CC = $(CROSS_COMPILE)gcc
>>
>> +TEST_STR = ./get_size || echo get_size selftests: [FAIL]
>> +
>> all: get_size
>>
>> get_size: get_size.c
>> $(CC) -static -ffreestanding -nostartfiles -s $< -o $@
>>
>> +install:
>> +ifdef INSTALL_KSFT_PATH
>> + install ./get_size $(INSTALL_KSFT_PATH)
>> + @echo "$(TEST_STR)" >> $(KSELFTEST)
>> +else
>> + @echo Run make kselftest_install in top level source directory
>> +endif
>> +
>> run_tests: all
>> - ./get_size
>> + @$(TEST_STR)
>>
>> clean:
>> $(RM) get_size
>>
>
> The install phase is desperately needed for usage of kselftest in
> cross-target situations (applicable to almost all embedded). So this
> is great stuff.
Thanks.
>
> I worked a bit on isolating the install stuff to a makefile include file.
> This allows simplifying some of the sub-level Makefiles a bit, and allowing
> control of some of the install and run logic in less places.
>
> This is still a work in progress, but before I got too far along, I wanted
> to post it for people to provide feedback. A couple of problems cropped
> up that are worth discussing, IMHO.
>
> 1) I think it should be a requirement that each test has a single
> "main" program to execute to run the tests. If multiple tests are supported
> or more flexibility is desired for additional arguments, or that sort of
> thing, then that's fine, but the automated script builder should be able
> to run just a single program or script to have things work. This also
> makes things more consistent. In the case of the firmware test, I created
> a single fw_both.sh script to do this, instead of having two separate
> blocks in the kselftest.sh script.
It is a good goal for individual tests to use a main program to run
tests, even though, I would not make it a requirement. I would like to
leave that decision up to the individual test writer.
>
> 2) I've added a CROSS_INSTALL variable, which can call an arbitrary program
> to place files on the target system (rather than just calling 'install').
> In my case, I'd use my own 'ttc cp' command, which I can extend as necessary
> to put things on a remote machine. This works for a single directory,
> but things get dicier with sub-directory trees full of files (like
> the ftrace test uses.)
>
> If additional items need to be installed to the target, then maybe a setup
> program should be used, rather than just copying files.
>
> 3) Some of the scripts were using /bin/bash to execute them, rather
> than rely on the interpreter line in the script itself (and having
> the script have executable privileges). Is there a reason for this?
> I modified a few scripts to be executable, and got rid of the
> explicit execution with /bin/bash.
Probably no reason other than the choice made by the test writer.
It could be cleaned up and made consistent, however, I would see
this as a separate enhancement type work that could be done on its
own and not include it in the install work.
>
> The following is just a start... Let me know if this direction looks
> OK, and I'll finish this up. The main item to look at is
> kselftest.include file. Note that these patches are based on Shuah's
> series - but if you want to use these ideas I can rebase them onto
> mainline, and break them out per test sub-level like Shuah did.
One of the reasons I picked install target approach is to enable the
feature by extending the existing run_tests support. This way we will
have the feature available quickly. Once that is supported, we can work
on evolving to a generic approach to use the include file approach, as
the changes you are proposing are based on the the series I sent out,
and makes improvements to it.
kselftest.include file approach could work for several tests and tests
that can't use the generic could add their own install support.
I propose evolving to a generic kselftest.include as the second step in
evolving the install feature. Can I count on you do the work and update
the tests to use kselftest.include, CROSS_INSTALL variable support?
thanks,
-- Shuah
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-05 21:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 16:27 [PATCH v3 00/20] kselftest install target feature Shuah Khan
2014-12-24 16:27 ` [PATCH v3 01/20] selftests/breakpoints: add install target to enable test install Shuah Khan
2014-12-24 16:27 ` [PATCH v3 02/20] selftests/cpu-hotplug: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 03/20] selftests/efivarfs: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 04/20] selftests/firmware: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 05/20] selftests/ftrace: " Shuah Khan
2015-01-02 15:45 ` Steven Rostedt
2015-01-04 5:18 ` Masami Hiramatsu
2015-01-04 5:29 ` Masami Hiramatsu
2015-01-05 18:06 ` Shuah Khan
2014-12-24 16:27 ` [PATCH v3 06/20] selftests/ipc: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 07/20] selftests/kcmp: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 08/20] selftests/memfd: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 09/20] selftests/memory-hotplug: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 10/20] selftests/mount: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 11/20] selftests/mqueue: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 12/20] selftests/net: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 13/20] selftests/ptrace: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 14/20] selftests/size: " Shuah Khan
2015-01-01 2:31 ` WIP alternative - was " Tim Bird
2015-01-05 21:28 ` Shuah Khan [this message]
2015-01-05 21:56 ` Tim Bird
2015-01-07 23:22 ` Shuah Khan
2014-12-24 16:27 ` [PATCH v3 15/20] selftests/sysctl: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 16/20] selftests/timers: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 17/20] selftests/user: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 18/20] selftests/vm: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 19/20] selftests: " Shuah Khan
2014-12-24 16:27 ` [PATCH v3 20/20] kbuild: add a new kselftest_install make target to install selftests Shuah Khan
2014-12-29 4:53 ` [PATCH v3 00/20] kselftest install target feature Michael Ellerman
2014-12-29 15:24 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AB0215.5020409@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=koct9i@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=serge.hallyn@ubuntu.com \
--cc=tim.bird@sonymobile.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).