From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from seldrel01.sonyericsson.com ([212.209.106.2]:16255 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbbAGXFy (ORCPT ); Wed, 7 Jan 2015 18:05:54 -0500 Message-ID: <54ADBBC8.30802@sonymobile.com> Date: Wed, 7 Jan 2015 15:05:44 -0800 From: Tim Bird MIME-Version: 1.0 Subject: Re: [PATCH v4 14/20] selftests/size: add install target to enable test install References: <5861e16e1b533cae37471a8cf18597d3e9e6b6f6.1420571615.git.shuahkh@osg.samsung.com> In-Reply-To: <5861e16e1b533cae37471a8cf18597d3e9e6b6f6.1420571615.git.shuahkh@osg.samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Shuah Khan , "mmarek@suse.cz" , "gregkh@linuxfoundation.org" , "akpm@linux-foundation.org" , "rostedt@goodmis.org" , "mingo@redhat.com" , "davem@davemloft.net" , "keescook@chromium.org" , "tranmanphong@gmail.com" , "mpe@ellerman.id.au" , "cov@codeaurora.org" , "dh.herrmann@gmail.com" , "hughd@google.com" , "bobby.prani@gmail.com" , "serge.hallyn@ubuntu.com" , "ebiederm@xmission.com" , "josh@joshtriplett.org" , "koct9i@gmail.com" , "masami.hiramatsu.pt@hitachi.com" Cc: "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "netdev@vger.kernel.org" On 01/06/2015 11:43 AM, Shuah Khan wrote: > Add a new make target to enable installing test. This target > installs test in the kselftest install location and add to the > kselftest script to run the test. Install target can be run > only from top level kernel source directory. > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/size/Makefile | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile > index 04dc25e..a1478fa 100644 > --- a/tools/testing/selftests/size/Makefile > +++ b/tools/testing/selftests/size/Makefile > @@ -1,12 +1,22 @@ > CC = $(CROSS_COMPILE)gcc > > +TEST_STR = ./get_size || echo 'get_size selftests: [FAIL]' > + > all: get_size > > get_size: get_size.c > $(CC) -static -ffreestanding -nostartfiles -s $< -o $@ > > +install: > +ifdef INSTALL_KSFT_PATH > + install ./get_size $(INSTALL_KSFT_PATH) > + @echo "$(TEST_STR)" >> $(KSELFTEST) > +else > + @echo "Run make kselftest_install in top level source directory" > +endif > + > run_tests: all > - ./get_size > + @$(TEST_STR) > > clean: > $(RM) get_size > Acked-by: Tim Bird