From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Shuah Khan <shuah@kernel.org>, Kees Cook <keescook@chromium.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
Tim.Bird@sony.com, kernel@collabora.com,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] Makefile: replace headers_install with headers for kselftest
Date: Tue, 19 Jul 2022 14:37:15 +0200 [thread overview]
Message-ID: <8fc9d169-78ff-0fe4-67c0-784097861f12@collabora.com> (raw)
In-Reply-To: <f35a71d6-bd96-7aa9-c143-39ae88bc85d5@linuxfoundation.org>
On 14/07/2022 22:45, Shuah Khan wrote:
> On 7/13/22 12:33 AM, Guillaume Tucker wrote:
>> Replace headers_install with headers as kselftest uses the header
>> files from within the kernel tree rather than from a system-wide
>> installation.
>>
>> We can still run this directly:
>>
>> $ make O=build kselftest-all
>>
>> and when building from the selftests directory:
>>
>> $ make O=build headers
>> $ make O=build -C tools/testing/selftests all
>>
>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>> Reported-by: Masahiro Yamada <masahiroy@kernel.org>
>> ---
>> Makefile | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index fb2f3bb53a6b..5c934d16664c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1347,10 +1347,10 @@ tools/%: FORCE
>> # Kernel selftest
>> PHONY += kselftest
>> -kselftest: headers_install
>> +kselftest: headers
>> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>> -kselftest-%: headers_install FORCE
>> +kselftest-%: headers FORCE
>> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
>> PHONY += kselftest-merge
>>
>
> Thank you for taking care of this. This will go through kbuild?
You're welcome.
Masahiro-san,
A you OK with applying this in the kbuild tree ahead of the
upcoming merge window?
Best wishes,
Guillaume
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>
> thanks,
> -- Shuah
>
next prev parent reply other threads:[~2022-07-19 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 6:33 [PATCH] Makefile: replace headers_install with headers for kselftest Guillaume Tucker
2022-07-14 20:45 ` Shuah Khan
2022-07-19 12:37 ` Guillaume Tucker [this message]
2022-07-19 15:06 ` Masahiro Yamada
2022-07-19 17:31 ` Guillaume Tucker
2022-07-27 0:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fc9d169-78ff-0fe4-67c0-784097861f12@collabora.com \
--to=guillaume.tucker@collabora.com \
--cc=Tim.Bird@sony.com \
--cc=anders.roxell@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).