From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Rob Herring <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
Tom Rini <trini@konsulko.com>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v2] kbuild: Enable DT schema checks for %.dtb targets
Date: Wed, 8 Dec 2021 22:37:50 +0000 [thread overview]
Message-ID: <9efecfd9-4021-642b-7dd0-dc03b24b336a@alliedtelesis.co.nz> (raw)
In-Reply-To: <CAL_JsqKqcCD+0ymW_km874A+HMeONBCF5Zgu352mwr-nNjDeqA@mail.gmail.com>
On 9/12/21 10:31 am, Rob Herring wrote:
> On Mon, Dec 6, 2021 at 1:34 AM Chris Packham
> <Chris.Packham@alliedtelesis.co.nz> wrote:
>> Hi Rob,
>>
>> On 14/09/21 2:51 am, Rob Herring wrote:
>>> It is possible to build a single dtb, but not with DT schema validation
>>> enabled. Enable the schema validation to run for %.dtb and %.dtbo
>>> targets. Anyone building a dtb for a specific platform *should* pay
>>> attention to schema warnings.
>>>
>>> This could be supported with a separate %.dt.yaml target instead.
>>> However, the .dt.yaml format is considered an intermediate format and
>>> could possibly go away at some point if schema checking is integrated
>>> into dtc. Also, the plan is to enable the schema checks by default once
>>> platforms are free of warnings, and this is a move in that direction.
>> Just started building 5.16-rc4 and hit the following error
>>
>> /usr/src/linux/scripts/dtc/Makefile:23: *** dtc needs libyaml for DT
>> schema validation support. Install the necessary libyaml development
>> package.. Stop.
>> make: *** [/usr/src/linux/Makefile:1405: scripts_dtc] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>> I tracked it back to this patch and I gather that the "error" is very
>> much intended. Fixing it means I need to get a native libyaml into my
>> cross toolchain, which is doable but a bit of a hassle. This probably
>> affects other meta build systems like buildroot and yocto.
> Yes. I'm going to revert this for now.
>
> Are python dependencies any easier? The libyaml dtc dependency may
> actually go away, but dtschema and it's dependencies will remain.
Probably no worse that non python dependencies.
Our particular special in-house build system might be a bit trickier as
we can't just spin up a vitrualenv but that's our problem not yours. We
do manage to build other packages that have build-time python
dependencies so I'm sure we could make that work for the kernel. I'm not
sure how much push-back you'd get from others if python became a
dependency for building the kernel.
>> I think I understand what you're getting at but is it possible to have
>> some kind of escape hatch to avoid having to add a build time tool
>> dependency (or even bundling libyaml next to scripts/dtc)?
> My current thought is to make it a kconfig option. I assume that would
> work for you?
An option would work for us. It could also be the kind of thing that
kicks in with make C=1/2.
I presume that you would want people to run this kind of thing when
submitting new bindings or board.dts. For us we can do those builds
manually outside our full build system.
>> I also notice that when I do supply a toolchain with libyaml the build
>> times are impacted by a noticable factor.
> How many dtbs are you building?
Nothing excessive. Something in the order of 7 depending on the
architecture. It's avoided on most re-builds so generally it's just a
one-off cost but it would affect any type of CI system that builds from
clean.
>
> Rob
prev parent reply other threads:[~2021-12-08 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:51 [PATCH v2] kbuild: Enable DT schema checks for %.dtb targets Rob Herring
2021-09-13 15:19 ` Masahiro Yamada
2021-12-06 7:34 ` Chris Packham
2021-12-08 21:31 ` Rob Herring
2021-12-08 22:37 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9efecfd9-4021-642b-7dd0-dc03b24b336a@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=robh@kernel.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).