From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E8BC433EF for ; Sun, 22 May 2022 14:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235614AbiEVOQ2 (ORCPT ); Sun, 22 May 2022 10:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240313AbiEVOQ1 (ORCPT ); Sun, 22 May 2022 10:16:27 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C70F1CB37; Sun, 22 May 2022 07:16:26 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id a10so12976893ioe.9; Sun, 22 May 2022 07:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=3dfbftv0bHItknlzHvUMl9TypfZzWyDtE0vtZuY9/u4=; b=MHTLDzSqR55aJLipGdUoc1ij6dSycjmCtcPhxekYYtNoAaTpxDgNlFEJiNWSvuCPKk YqPMjRwVBlCIpm8BoCjocOl+ryyq2axnL0Ag06xaO8Bv0BJV+E7L4n5Fs03F+SJIf3z2 2RmvJtOjN8l8ZPXYdnLn8p9j+TfpxjorO7S4ssdtYjIm23PSZ0lDRAMo7DmrUmTomSJm I135LF5cD/TxFPDEEkJ7wyEQQfo6COQCUYwF8upa8nM/abv6UJgBTUj33wDdK1nwtU5i bsaTHXNb0MVpQA6KpIyFG6mj1rbeAdiusPNFOWy0aWtL37ygRJhXmeNX0rm/4b33euRY kwow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=3dfbftv0bHItknlzHvUMl9TypfZzWyDtE0vtZuY9/u4=; b=MJlsr7oOTp8fmlxHm89o/GUR0wfawX0J7tdqV/o8u2WBpdRWa6lkzh8SZZN2nQwp0X Ufe6pgloqP6vmD0sjz3oL6VY8QTnhF3DA9yxQPg0YtwSk4t9MI+nCMsvFmGRrhGGHSgZ B5edlBl7H7uBERzmKCI9Ac60xsvQ0yYQqzFnMunxWMi4A0mEE593lcQ2wGU24H+LOK/f xEN8c8gHyWojtKdbCvTcgtKAS/k3bWAOE7oTMNYRDz3laygstPcXzq8GA33pogm9BZWj qk5SlrR1c1/1rD8Y9340qQIIs5CnSqf2jqhokGzeU2OD60rDjlgQP6tAhRp+pvUyv93z YADg== X-Gm-Message-State: AOAM531Jp3L0Ud6CNZuM7cbEagRuTfd+4rzL6BvjdWl1YuVa6WbWvp5f OMLJZsqUQo2iW+AD8i3dFZ7cvfkebdcUzRj3jeI= X-Google-Smtp-Source: ABdhPJw1CV7WTOX07Dg1AJ+AhSUJ6vQaIcAn8P91Nmcnn2lOvrQfZXjGzRCF2gJknGRsDu4GWUaiXA7t05oIb69dBIg= X-Received: by 2002:a05:6638:14cb:b0:32e:cf97:4ac with SMTP id l11-20020a05663814cb00b0032ecf9704acmr198855jak.80.1653228985425; Sun, 22 May 2022 07:16:25 -0700 (PDT) MIME-Version: 1.0 References: <20220513113930.10488-1-masahiroy@kernel.org> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Sun, 22 May 2022 16:15:49 +0200 Message-ID: Subject: Re: [PATCH v6 00/10] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) To: Masahiro Yamada Cc: Linux Kbuild mailing list , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Peter Zijlstra , linux-modules , clang-built-linux , Ard Biesheuvel , Sami Tolvanen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Sun, May 22, 2022 at 11:45 AM Sedat Dilek wrote: > > On Sun, May 22, 2022 at 8:50 AM Masahiro Yamada wrote: > > > > On Sun, May 22, 2022 at 10:45 AM Sedat Dilek wrote: > > > > > > On Fri, May 13, 2022 at 4:31 PM Masahiro Yamada wrote: > > > > > > > > On Fri, May 13, 2022 at 8:42 PM Masahiro Yamada wrote: > > > > > > > > > > > > > > > This is the third batch of cleanups in this development cycle. > > > > > > > > > > > > > > > > > This series is available at > > > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > > > > lto-cleanup-v6 > > > > > > > > > > Hi Masahiro, > > > > > > I cloned the repository on top of latest Linus Git. > > > > > > Not able to boot in Quemu - Not able to boot on bare metal. > > > > > > $ grep module_layout log_quemu-5.18.0-rc7-2-amd64-clang14-lto.txt > > > 366:[ 2.173265] floppy: disagrees about version of symbol module_layout > > > 367:[ 2.198746] scsi_common: disagrees about version of symbol module_layout > > > 368:[ 2.205573] i2c_piix4: disagrees about version of symbol module_layout > > > 369:[ 2.210610] psmouse: disagrees about version of symbol module_layout > > > 370:[ 2.225138] scsi_common: disagrees about version of symbol module_layout > > > 371:[ 2.235536] scsi_common: disagrees about version of symbol module_layout > > > 375:Begin: Running /scripts/local-premount ... [ 2.298555] > > > crc32c_intel: disagrees about version of symbol module_layout > > > 376:[ 2.303335] crc32c_generic: disagrees about version of symbol > > > module_layout > > > 377:[ 2.306667] libcrc32c: disagrees about version of symbol module_layout > > > > > > Infos: LLVM-14 + CONFIG_LTO_CLANG_THIN=y > > > > > > My linux-config and qemu-log are attached. > > > > > > > > > Thanks for your testing. > > > > I was also able to reproduce this issue. > > > > > > The problematic parts are: > > > > [ 2.298555] crc32c_intel: disagrees about version of symbol module_layout > > [ 2.303335] crc32c_generic: disagrees about version of symbol module_layout > > [ 2.306667] libcrc32c: disagrees about version of symbol module_layout > > > > > > > > When CONFIG_LTO_CLANG_THIN=y, > > I cannot see any __crc_* symbols in "nm vmlinux". > > > > Perhaps, LTO might have discarded all the __crc_* symbols > > from vmlinux, but I am still checking the details... > > > > Thanks for taking care. > > Just for the records: > > $ grep CONFIG_MODVERSIONS /boot/config-5.18.0-rc7-2-amd64-clang14-lto > CONFIG_MODVERSIONS=y > Did not try CONFIG_MODVERSIONS=n. We have a new file: [ include/linux/export-internal.h ] /* SPDX-License-Identifier: GPL-2.0-only */ /* * Please do not include this explicitly. * This is used by C files generated by modpost. */ #ifndef __LINUX_EXPORT_INTERNAL_H__ #define __LINUX_EXPORT_INTERNAL_H__ #include #include #define SYMBOL_CRC(sym, crc, sec) \ u32 __section("___kcrctab" sec "+" #sym) __crc_##sym = crc #endif /* __LINUX_EXPORT_INTERNAL_H__ */ But we discard __kcrctab in scripts/module.lds.S file. Maybe we need: $ git diff scripts/module.lds.S diff --git a/scripts/module.lds.S b/scripts/module.lds.S index 1d0e1e4dc3d2..c04b596c364b 100644 --- a/scripts/module.lds.S +++ b/scripts/module.lds.S @@ -21,8 +21,6 @@ SECTIONS { __ksymtab 0 : { *(SORT(___ksymtab+*)) } __ksymtab_gpl 0 : { *(SORT(___ksymtab_gpl+*)) } - __kcrctab 0 : { *(SORT(___kcrctab+*)) } - __kcrctab_gpl 0 : { *(SORT(___kcrctab_gpl+*)) } .ctors 0 : ALIGN(8) { *(SORT(.ctors.*)) *(.ctors) } .init_array 0 : ALIGN(8) { *(SORT(.init_array.*)) *(.init_array) } Or even? $ git diff scripts/kallsyms.c diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index 8caabddf817c..fb3601fe8aa3 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -109,7 +109,6 @@ static bool is_ignored_symbol(const char *name, char type) static const char * const ignored_prefixes[] = { "$", /* local symbols for ARM, MIPS, etc. */ ".L", /* local labels, .LBB,.Ltmpxxx,.L__unnamed_xx,.LASANPC, etc. */ - "__crc_", /* modversions */ "__efistub_", /* arm64 EFI stub namespace */ "__kvm_nvhe_", /* arm64 non-VHE KVM namespace */ "__AArch64ADRPThunk_", /* arm64 lld */ - Sedat -