From: Masahiro Yamada <masahiroy@kernel.org>
To: Dmitry Goncharov <dgoncharov@users.sf.net>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: Port silent mode detection to future gnu make.
Date: Tue, 29 Nov 2022 15:18:48 +0900 [thread overview]
Message-ID: <CAK7LNAQn248OsEGXCRFNURt7VC6eNfu-EEtphdtw9uNJPD_16Q@mail.gmail.com> (raw)
In-Reply-To: <CAG+Z0CvGfuMpM+VpMaPJVY9EjrDztJxMgYKW2Tp_XR1SX0Xxxg@mail.gmail.com>
On Tue, Nov 29, 2022 at 12:00 PM Dmitry Goncharov
<dgoncharov@users.sf.net> wrote:
>
> Good morning.
>
> On Sun, Nov 27, 2022 at 1:02 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > Please come back after your patch is applied
> > (and please have the patch include the commit hash
> > causing the behaviour change)
>
>
>
> The change is available in git in sha dc2d963989b96161472b2cd38cef5d1f4851ea34.
>
> regards, Dmitry
>
> diff --git a/Makefile b/Makefile
> index 6f846b1f2618..c5d5558e9806 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -94,7 +94,7 @@ endif
> # If the user is running make -s (silent mode), suppress echoing of
> # commands
>
> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),)
> quiet=silent_
> KBUILD_VERBOSE = 0
> endif
Yup, I saw that.
Paul said with GNU Make 4.4,
Kbuild is already having an issue in the -s detection.
$ export MAKEFLAGS=-I/usr/local/mk
or
$ export MAKEFLAGS=-Orecurse
Commit 77881d228103 ("Ensure that MAKEFLAGS is set when invoking $(shell ...)")
is the commit that caused a change.
Please send v2 with $(firstword) and updated commit log.
Also, add this tag:
Link: https://lists.gnu.org/archive/html/bug-make/2022-11/msg00190.html
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2022-11-29 6:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAG+Z0CviRhBQqWfAPFDht+mWUJf4azPSZgOV0jrur_YSP23__A@mail.gmail.com>
2022-11-27 5:46 ` Port silent mode detection to future gnu make Masahiro Yamada
2022-11-27 15:36 ` Dmitry Goncharov
2022-11-29 3:00 ` Dmitry Goncharov
2022-11-29 6:18 ` Masahiro Yamada [this message]
2022-11-29 17:27 ` Dmitry Goncharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQn248OsEGXCRFNURt7VC6eNfu-EEtphdtw9uNJPD_16Q@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=dgoncharov@users.sf.net \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).