From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Michal Marek <mmarek@suse.com>,
Guenter Roeck <groeck@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Marcin Nowakowski <marcin.nowakowski@imgtec.com>,
Matthias Kaehlcke <mka@chromium.org>,
Behan Webster <behanw@converseincode.com>,
Arnd Bergmann <arnd@arndb.de>,
Mark Charlebois <charlebm@gmail.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables
Date: Tue, 10 Oct 2017 09:52:50 +0900 [thread overview]
Message-ID: <CAK7LNAR0Gpk9U1gaCFn6CiOJUGr5jc+Pcz8vSP9GJRhchjWedQ@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=VbRbvmqVK7iNG6xx3MD1vsCKRY=tW=K8Q71MoQkCFMOw@mail.gmail.com>
2017-10-06 5:58 GMT+09:00 Doug Anderson <dianders@chromium.org>:
> Hi,
>
> On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> As far as I tested, I always see only one space after ":=" in v2.
>>
>> I did not consider this deeply,
>> but something is working nicely behind the scene.
>
> Try adding this to the end of the main Makefile:
>
> +$(info LDFLAGS_BUILD_ID = $(LDFLAGS_BUILD_ID))
> +$(info KBUILD_ARFLAGS = $(KBUILD_ARFLAGS))
> +$(info KBUILD_CFLAGS = $(KBUILD_CFLAGS))
> +$(info KBUILD_AFLAGS = $(KBUILD_AFLAGS))
> +$(info KBUILD_CPPFLAGS = $(KBUILD_CPPFLAGS))
> +$(info REALMODE_CFLAGS = $(REALMODE_CFLAGS))
> +
> endif # skip-makefile
>
> Record what you see. Then apply my patches and run your build again
> (actually, run it twice and look at the 2nd time, just to be sure). I
> think you'll see slightly different spacing in the flags for the two
> runs. I don't think this is terribly important, though.
>
Yes. I see slight difference
in the resulted KBUILD_CFLAGS etc.
What I meant is:
In v2, I always see only one space after the assignment operator ":="
in .cache.mk
even without $(strip )
$(call cc-option,-fno-PIE)
$(call cc-option, -fno-PIE)
$(call cc-option, -fno-PIE)
All of the three gave me the same result.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2017-10-10 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 17:55 [RFC PATCH 0/2] kbuild: Cache exploratory calls to the compiler Douglas Anderson
2017-09-26 17:55 ` [RFC PATCH 1/2] kbuild: Add a cache for generated variables Douglas Anderson
2017-10-04 4:05 ` Masahiro Yamada
2017-10-04 22:38 ` Doug Anderson
2017-10-05 7:26 ` Masahiro Yamada
2017-10-05 20:58 ` Doug Anderson
2017-10-10 0:52 ` Masahiro Yamada [this message]
2017-09-26 17:55 ` [RFC PATCH 2/2] kbuild: Cache a few more calls to the compiler Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAR0Gpk9U1gaCFn6CiOJUGr5jc+Pcz8vSP9GJRhchjWedQ@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=briannorris@chromium.org \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=charlebm@gmail.com \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.nowakowski@imgtec.com \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).