linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>
Subject: Re: [PATCH] kbuild: get lib-y objects back to static library
Date: Thu, 24 Aug 2023 10:44:29 +0900	[thread overview]
Message-ID: <CAK7LNASDi7RTBk6z4=J8mtyoRd7-NKD36d2fGwtkA_=tdmka0g@mail.gmail.com> (raw)
In-Reply-To: <20230823120816.824352-1-masahiroy@kernel.org>

On Thu, Aug 24, 2023 at 10:05 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Revert the following two commits:
>
>  - 7273ad2b08f8 ("kbuild: link lib-y objects to vmlinux forcibly when CONFIG_MODULES=y")
>  - 7f2084fa55e6 ("[kbuild] handle exports in lib-y objects reliably")
>
> Now, lib-y is back to static library again, and the link order is
> consistent w/wo CONFIG_MODULES.
>
> Since commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
> modpost"), .vmlinux.export.c contains references to exported symbols.
> If a symbol in a lib-y object is exported, that object is always linked
> even without any explicit user in vmlinux.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---



I just recalled that presumably ARM code must be fixed beforehand.

https://lore.kernel.org/lkml/20230619143725.57967-1-masahiroy@kernel.org/

$(mmu-y) is added to lib-y, but they cannot go into a static library.







-- 
Best Regards
Masahiro Yamada

  parent reply	other threads:[~2023-08-24  1:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 12:08 [PATCH] kbuild: get lib-y objects back to static library Masahiro Yamada
2023-08-23 20:20 ` Nathan Chancellor
2023-08-24 18:59   ` Nathan Chancellor
2023-08-25 16:58     ` Nick Desaulniers
2023-08-26  0:06       ` Masahiro Yamada
2023-08-26  0:55         ` Nick Desaulniers
2023-08-24  1:44 ` Masahiro Yamada [this message]
2023-08-26  2:37 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNASDi7RTBk6z4=J8mtyoRd7-NKD36d2fGwtkA_=tdmka0g@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).