Re: [PATCH 4/8] scripts/kallsyms: exclude symbols generated by itself dynamically

[Masahiro Yamada <masahiroy@kernel.org>]

On Sat, Apr 8, 2023 at 5:13 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Wed, Mar 8, 2023 at 3:53 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Drop the symbols generated by scripts/kallsyms itself automatically
> > instead of maintaining the symbol list manually.
> >
> > Pass the kallsyms object from the previous kallsyms step (if it exists)
> > as the third parameter of scripts/mksysmap, which will weed out the
> > generated symbols from the input to the next kallsyms step.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  scripts/kallsyms.c      | 17 -----------------
> >  scripts/link-vmlinux.sh |  6 +++---
> >  scripts/mksysmap        | 11 ++++++++++-
> >  3 files changed, 13 insertions(+), 21 deletions(-)
> >
> > diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> > index 8148e880f78e..e572fda6fe42 100644
> > --- a/scripts/kallsyms.c
> > +++ b/scripts/kallsyms.c
> > @@ -104,23 +104,6 @@ static bool is_ignored_symbol(const char *name, char type)
> >  {
> >         /* Symbol names that exactly match to the following are ignored.*/
> >         static const char * const ignored_symbols[] = {
> > -               /*
> > -                * Symbols which vary between passes. Passes 1 and 2 must have
> > -                * identical symbol lists. The kallsyms_* symbols below are
> > -                * only added after pass 1, they would be included in pass 2
> > -                * when --all-symbols is specified so exclude them to get a
> > -                * stable symbol list.
> > -                */
> > -               "kallsyms_addresses",
> > -               "kallsyms_offsets",
> > -               "kallsyms_relative_base",
> > -               "kallsyms_num_syms",
> > -               "kallsyms_names",
> > -               "kallsyms_markers",
> > -               "kallsyms_token_table",
> > -               "kallsyms_token_index",
> > -               "kallsyms_seqs_of_names",
> > -               /* Exclude linker generated symbols which vary between passes */
>
> ^ Do we want to retain this comment for the below two symbols?



Correct.

I will keep the comment, but it will be removed
in the next commit, 5/8 because all the ignored patterns
will go away anyway.

Thanks.




>
> >                 "_SDA_BASE_",           /* ppc */
> >                 "_SDA2_BASE_",          /* ppc */
> >                 NULL



--
Best Regards
Masahiro Yamada