linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Guillem Jover <guillem@hadrons.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] builddeb: Pass -n to gzip for reproducible packages
Date: Fri, 9 Oct 2020 23:58:57 +0900	[thread overview]
Message-ID: <CAK7LNAS_3EOYMcS-cMnEZVED_JUQa+rZottbqwD4fppC7ZXdmg@mail.gmail.com> (raw)
In-Reply-To: <20200920222556.10002-2-guillem@hadrons.org>

On Mon, Sep 21, 2020 at 7:48 AM Guillem Jover <guillem@hadrons.org> wrote:
>
> We should not be encoding the timestamp, otherwise we end up generating
> unreproducible files that cascade into unreproducible packages.
>
> Signed-off-by: Guillem Jover <guillem@hadrons.org>


Applied to linux-kbuild.
Thanks.

> ---
>  scripts/package/builddeb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index 6df3c9f8b2da..b14abbe5afbb 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -31,7 +31,7 @@ create_package() {
>         mkdir -p "$pdir/usr/share/doc/$pname"
>         cp debian/copyright "$pdir/usr/share/doc/$pname/"
>         cp debian/changelog "$pdir/usr/share/doc/$pname/changelog.Debian"
> -       gzip -9 "$pdir/usr/share/doc/$pname/changelog.Debian"
> +       gzip -n -9 "$pdir/usr/share/doc/$pname/changelog.Debian"
>         sh -c "cd '$pdir'; find . -type f ! -path './DEBIAN/*' -printf '%P\0' \
>                 | xargs -r0 md5sum > DEBIAN/md5sums"
>
> --
> 2.28.0.297.g1956fa8f8d
>


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2020-10-09 15:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-20 22:25 [PATCH 0/7] builddeb: Improve Debian packaging Guillem Jover
2020-09-20 22:25 ` [PATCH 1/7] builddeb: Pass -n to gzip for reproducible packages Guillem Jover
2020-10-09 14:58   ` Masahiro Yamada [this message]
2020-09-20 22:25 ` [PATCH 2/7] builddeb: Move upstream repository URL into the upstream metadata file Guillem Jover
2020-09-20 22:25 ` [PATCH 3/7] builddeb: Switch to a machine readable copyright file Guillem Jover
2020-09-28 15:11   ` Masahiro Yamada
2020-09-20 22:25 ` [PATCH 4/7] builddeb: Add support for all required debian/rules targets Guillem Jover
2020-10-09 15:46   ` Masahiro Yamada
2020-09-20 22:25 ` [PATCH 5/7] builddeb: Enable rootless builds Guillem Jover
2020-10-09 15:46   ` Masahiro Yamada
2020-09-20 22:25 ` [PATCH 6/7] builddeb: Map rc versions to use an earlier than version scheme Guillem Jover
2020-09-20 22:25 ` [PATCH 7/7] builddeb: Try to get the user full name from the GECOS field Guillem Jover
2020-09-28 15:21 ` [PATCH 0/7] builddeb: Improve Debian packaging Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNAS_3EOYMcS-cMnEZVED_JUQa+rZottbqwD4fppC7ZXdmg@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=guillem@hadrons.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).